Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Exclude top-level self accesses from trackModule #10245

Merged
merged 1 commit into from Sep 1, 2022
Merged

Ruby: Exclude top-level self accesses from trackModule #10245

merged 1 commit into from Sep 1, 2022
+8 −8

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 31, 2022 •
edited

When debugging a performance problem related to the call graph, I noticed that trackInstance could yield multiple results for top-level self accesses. This PR removes multiplicity by ruling out top-level accesses in trackModule, which means that in

def foo
end

self.foo

the self qualifier will only get type Object and not Class.

@github-actions github-actions bot added the Ruby label Aug 31, 2022
@hvitved hvitved force-pushed the ruby/simplify-track-instance branch from 5588feb to 4d48516 Compare Sep 1, 2022
@hvitved hvitved changed the title Ruby: Simplify trackInstance Ruby: Exclude top-level self accesses from trackModule Sep 1, 2022
@hvitved hvitved marked this pull request as ready for review Sep 1, 2022
@hvitved hvitved requested a review from a team as a code owner Sep 1, 2022
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Sep 1, 2022
aibaars
aibaars approved these changes Sep 1, 2022
View changes
@hvitved hvitved merged commit 3c33907 into github:main Sep 1, 2022
23 of 24 checks passed
@hvitved hvitved deleted the ruby/simplify-track-instance branch Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hvitved @aibaars