C#: Remove legacy tracer support#10235
Merged
hvitved merged 3 commits intogithub:mainfrom Sep 2, 2022
Merged
Conversation
25653f9 to
18b5ab0
Compare
michaelnebel
approved these changes
Sep 1, 2022
Contributor
michaelnebel
left a comment
There was a problem hiding this comment.
Looks plausible to me!
Contributor
|
@hvitved awesome fix! Missing the shared compilation flag is not always obvious as it just creates a small DB w/o errors. Just hit this this week in a POC!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy tracer specifications, and moves the responsibility of disabling shared compilation (and pre-compilation of ASP.NET MVC code) from the auto-builder to the tracer, which means that it will also work with custom build commands.
Commit-by-commit review is suggested.