Merged
Conversation
This also showcases the customizability of the `PrintAst` infrastructure resting on generated code.
6e3ee80 to
aa54e4b
Compare
4046aa7 to
30049f6
Compare
MathiasVP
reviewed
Sep 2, 2022
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
The code LGTM, but I'm wondering if this is how we want the conversions to be laid out in the viewer.
MathiasVP
approved these changes
Sep 2, 2022
Comment on lines
+10
to
+15
| Expr getConversion(int n) { | ||
| n = 0 and result = this.getConversion() | ||
| or | ||
| result = this.getConversion(n - 1).getConversion() | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I suppose this predicate is unused now, but maybe it'll be a useful thing to have in the future. If so, we should maybe add a Expr.getAConversion() predicate as well in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the uncoverted node is still shown as a direct child, its conversions are listed in a new
conversionsvirtual child.Moreover,
VarDecl(includingParamDecl) instance show their type as a property, and so doAbstractFunctionDecl.This also showcases the customizability of the
PrintAstinfrastructure resting on generated code.