gh-96349: Fix minor performance regression initializing threading.Event#96350
Merged
corona10 merged 1 commit intopython:mainfrom Aug 30, 2022
Merged
Conversation
corona10
approved these changes
Aug 30, 2022
Member
corona10
left a comment
There was a problem hiding this comment.
LGTM, no reason not to merge
Mean +- std dev: [base] 1.53 us +- 0.01 us -> [pr] 493 ns +- 11 ns: 3.11x faster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a minor performance regression making it slightly slower to initialize a
threading.Eventon the main branch than it was in 3.10. I think the slowdown may have been related to zero-cost exceptions.This PR removes the slowdown (and makes it faster than it was before).
Here's a simple benchmark with pyperf:
3.10:
Main branch:
With this PR: