QL: remove consistency errors related to resolving multiple predicates from parameterized modules #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from parameterized modules
kaeluka
previously approved these changes
Aug 26, 2022
I've tried to understand this PR and my interpretation is that you're seeing consistency errors due to this line:
If that interpretation is correct and you've read my other comment, merge away.
| resolvePredicateExpr(pe, p) | ||
| resolvePredicateExpr(pe, p) and | ||
| // parameterized modules are expected to resolve to multiple. | ||
| not exists(Predicate sig | not exists(sig.getBody()) and resolvePredicateExpr(pe, sig)) |
There was a problem hiding this comment.
not exists(sig.getBody) is the way you're checking that the predicate is part of a parameterized module interface? If so, I think that would well deserve a named predicate or a named class. A name would make this line easier to read, and it would also make it less likely that others in the future have to re-invent/re-discover this logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Predicate references in prameterized modules will resolve to multiple predicates, that's a feature (for now).
This fixes a FP in the consistency test related to that.