New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi devcontainer #5076
Merged
Merged
Multi devcontainer #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly reminder this should not be brought into a release until https://admin.github.com/devtools/feature_flags/codespaces_multi_devcontainer is fully enabled. |
|
If you could let me know the date this will be included in a CLI release I'd be grateful. There's a little docs update I'll need to make. Thanks |
|
The feature has been shipped. It is now safe to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The API endpoints that power this feature are guarded by feature flags so users noticing this flag on a release would not be at risk for harming anything, but we would not want to confuse anyone if we can avoid it. This branch should not be merged until the
:codespaces_multi_devcontainerfeature is fully shipped.Fixes github/codespaces#5597 and github/codespaces#7463
This change adds the
--devcontainer-pathflag to the CLI to pass along to the create API:For the create flow it also makes use of the
list-devcontainersAPI endpoint to provide a list of possible devcontainer.json file options for users in a prompt: