Java: support more libraries in hardcoded-credentials queries#10041
Merged
smowton merged 11 commits intogithub:mainfrom Aug 23, 2022
Merged
Java: support more libraries in hardcoded-credentials queries#10041smowton merged 11 commits intogithub:mainfrom
smowton merged 11 commits intogithub:mainfrom
Conversation
Specifically Apache sshd defines its sensitive api calls on an inherited interface, and they need to be described that way for us to pick them up.
java/ql/lib/semmle/code/java/security/HardcodedCredentialsApiCallQuery.qll
Fixed
Show fixed
Hide fixed
4ef22b7 to
e27d62b
Compare
atorralba
previously approved these changes
Aug 23, 2022
Contributor
atorralba
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this.
I always wonder, though — how much of this should be covered by secret scanning and not CodeQL?
atorralba
reviewed
Aug 23, 2022
java/ql/lib/semmle/code/java/security/HardcodedCredentialsComparison.qll
Show resolved
Hide resolved
atorralba
approved these changes
Aug 23, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is abandoned external PR #6716, but I have also written tests and ported the hardcoded-creds queries to use inline-expectations tests so it's practically possible to verify that the results are as expected.