C#: SQL Injection improvements for SQLite. #9923

michaelnebel · 2022-07-29T11:15:33Z

The content on this PR is to address the issue: https://github.com/github/codeql-csharp-team/issues/172
Following the link to the original ticket it is worth noticing that

The project referenced on the ticket doesn't build, which could lead to the missing results.
The project referenced on the ticket is fork of another project which does build and
- The claimed missing SQL injection is found by our query even though we don't directly support the SQLite framework.
- The claimed missing Second Order SQL injection is in parts of the code that isn't included in the build. That being said, the Second Order SQL injection query will not find this.

In this PR we

Provide better support for the SQLite framework.
- Explicit summaries for this Framework has been made, including Adapters (which was not supported before).
- Stubs for the SQLite framework has been included.
- Coding examples with weaknesses discovered by the SQL injection query are included.
FileStream and StreamReader summaries.
- Flow summaries for FileStream and StreamReader has been included.
- Example similar to the Second Order SQL injection has been provided and will no be caught as a first order SQL injection, if the filename is tainted.
FileStreams are now considered StoredFlowSources.
- FileStreams are now considered stored flow sources.
- Second Order SQL injection now catches an example similar to the one provided in the referenced ticket.

A change note will be added, when the exact scope of the PR is decided.

github-actions · 2022-07-29T11:18:51Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,12038,28,5
+    System,"``System.*``, ``System``",3,12044,36,5
-    Totals,,3,12599,359,5
+    Totals,,3,12605,367,5

Changes to framework-coverage-csharp.csv:

- System,28,3,12038,,4,,23,1,3,10096,1942
+ System,36,3,12044,,4,,31,1,3,10102,1942

github-actions · 2022-07-29T11:22:40Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,12038,28,5
+    System,"``System.*``, ``System``",3,12044,36,5
-    Totals,,3,12599,359,5
+    Totals,,3,12605,367,5

Changes to framework-coverage-csharp.csv:

- System,28,3,12038,,4,,23,1,3,10096,1942
+ System,36,3,12044,,4,,31,1,3,10102,1942

github-actions · 2022-08-02T07:19:31Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,32,7
+    System,"``System.*``, ``System``",3,11802,40,7
-    Totals,,3,12357,363,7
+    Totals,,3,12363,371,7

Changes to framework-coverage-csharp.csv:

- System,32,3,11796,,4,,25,3,3,9854,1942
+ System,40,3,11802,,4,,33,3,3,9860,1942

github-actions · 2022-08-02T11:52:08Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,32,7
+    System,"``System.*``, ``System``",4,11803,40,7
-    Totals,,3,12357,363,7
+    Totals,,4,12364,371,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,,
+ Dapper,55,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,73,18
- ServiceStack,194,,7,27,,75,92,,,7,
+ ServiceStack,194,,7,27,,75,92,,,,7,
- System,32,3,11796,,4,,25,3,3,9854,1942
+ System,40,4,11803,,4,,33,3,1,3,9861,1942

github-actions · 2022-08-02T13:08:40Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,32,7
+    System,"``System.*``, ``System``",4,11810,40,7
-    Totals,,3,12357,363,7
+    Totals,,4,12371,371,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,,
+ Dapper,55,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,73,18
- ServiceStack,194,,7,27,,75,92,,,7,
+ ServiceStack,194,,7,27,,75,92,,,,7,
- System,32,3,11796,,4,,25,3,3,9854,1942
+ System,40,4,11810,,4,,33,3,1,3,9868,1942

csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsources/Stored.qll

github-actions · 2022-08-02T13:21:11Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,32,7
+    System,"``System.*``, ``System``",4,11809,40,7
-    Totals,,3,12357,363,7
+    Totals,,4,12370,371,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,,
+ Dapper,55,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,73,18
- ServiceStack,194,,7,27,,75,92,,,7,
+ ServiceStack,194,,7,27,,75,92,,,,7,
- System,32,3,11796,,4,,25,3,3,9854,1942
+ System,40,4,11809,,4,,33,3,1,3,9867,1942

github-actions · 2022-08-02T13:39:10Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,32,7
+    System,"``System.*``, ``System``",4,11809,40,7
-    Totals,,3,12357,363,7
+    Totals,,4,12370,371,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,,
+ Dapper,55,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,73,18
- ServiceStack,194,,7,27,,75,92,,,7,
+ ServiceStack,194,,7,27,,75,92,,,,7,
- System,32,3,11796,,4,,25,3,3,9854,1942
+ System,40,4,11809,,4,,33,3,1,3,9867,1942

github-actions · 2022-08-02T13:51:31Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,32,7
+    System,"``System.*``, ``System``",4,11809,40,7
-    Totals,,3,12357,363,7
+    Totals,,4,12370,371,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,,
+ Dapper,55,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,73,18
- ServiceStack,194,,7,27,,75,92,,,7,
+ ServiceStack,194,,7,27,,75,92,,,,7,
- System,32,3,11796,,4,,25,3,3,9854,1942
+ System,40,4,11809,,4,,33,3,1,3,9867,1942

csharp/ql/lib/semmle/code/csharp/frameworks/Sql.qll

…nted command.

github-actions · 2022-08-10T09:13:28Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,35,7
+    System,"``System.*``, ``System``",4,11809,43,7
-    Totals,,3,12357,367,7
+    Totals,,4,12370,375,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,
+ Dapper,55,,,,,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,7,
- System,35,3,11796,,1,1,1,,4,,25,3,3,9854,1942
+ System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,

hvitved

Unit tests are failing; otherwise LGTM.

…ummaries.

…ulnerability from test case.

…tion (note that this is already a second order sql injection).

michaelnebel · 2022-08-10T13:00:00Z

Unit tests are failing; otherwise LGTM.

Yes, this is due to the rebase after the new stubs were generated. Will fix.
I will also add a release note and start DCA.

github-actions · 2022-08-10T13:02:31Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,35,7
+    System,"``System.*``, ``System``",4,11809,43,7
-    Totals,,3,12357,367,7
+    Totals,,4,12370,375,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,
+ Dapper,55,,,,,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,7,
- System,35,3,11796,,1,1,1,,4,,25,3,3,9854,1942
+ System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,

csharp/ql/src/change-notes/2022-08-10-sqlinjection-queries.md

github-actions · 2022-08-11T07:00:26Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,11796,35,7
+    System,"``System.*``, ``System``",4,11809,43,7
-    Totals,,3,12357,367,7
+    Totals,,4,12370,375,7

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,
+ Dapper,55,,,,,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,7,
- System,35,3,11796,,1,1,1,,4,,25,3,3,9854,1942
+ System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,

michaelnebel · 2022-08-11T07:06:12Z

Lots of projects failed in DCA. Will re-execute DCA as there is an alerts diff on the projects that succeeded (which is not totally unexpected).

michaelnebel · 2022-08-12T14:13:08Z

Comments on the DCA execution

There are no performance regressions.
The failure of ASP.NET Core is most likely unrelated (it fails with out of memory - the same was the case for the nightly run)
The new alerts are all for queries that use StoredFlowSource as a source of taint and the first step is opening a FileStream, which makes sense, since we are now considered a file a StoredFlowSource. Are these alerts something we want?

hvitved · 2022-08-15T09:39:43Z

The new alerts are all for queries that use StoredFlowSource as a source of taint and the first step is opening a FileStream, which makes sense, since we are now considered a file a StoredFlowSource. Are these alerts something we want?

AFAICT, there are no new results on WebGoat. Were we expecting that?

michaelnebel · 2022-08-15T10:15:45Z

The new alerts are all for queries that use StoredFlowSource as a source of taint and the first step is opening a FileStream, which makes sense, since we are now considered a file a StoredFlowSource. Are these alerts something we want?

AFAICT, there are no new results on WebGoat. Were we expecting that?

No, we were not expecting more results.
(1) The first order SQL injection result was already found without any changes.
(2) The second SQL injection result will not be a found as the references code is not included in the compilation of the project.

hvitved · 2022-08-15T11:14:40Z

the references code is not included in the compilation of the project

🤦

github-actions bot added the C# label Jul 29, 2022

michaelnebel force-pushed the csharp/webgoat branch from 879d16d to 0650877 Compare August 2, 2022 07:16

michaelnebel force-pushed the csharp/webgoat branch from 97d7d33 to 24729ee Compare August 2, 2022 13:05

github-advanced-security bot found potential problems Aug 2, 2022

View reviewed changes

csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsources/Stored.qll Fixed Show fixed Hide fixed

michaelnebel force-pushed the csharp/webgoat branch from 24729ee to c1ee553 Compare August 2, 2022 13:17

michaelnebel force-pushed the csharp/webgoat branch from c1ee553 to 04d1a1c Compare August 2, 2022 13:35

michaelnebel force-pushed the csharp/webgoat branch from 04d1a1c to c88e98d Compare August 2, 2022 13:48

michaelnebel marked this pull request as ready for review August 3, 2022 06:03

michaelnebel requested a review from a team as a code owner August 3, 2022 06:03

michaelnebel requested a review from hvitved August 3, 2022 06:03

hvitved reviewed Aug 8, 2022

View reviewed changes

csharp/ql/lib/semmle/code/csharp/frameworks/Sql.qll Show resolved Hide resolved

michaelnebel added 11 commits August 10, 2022 11:08

C#: Add SQLCommand examples.

d427527

C#: Add SQLiteCommand sinks.

6f9f771

C#: Update SQLInjection query test output.

ce9baaa

C#: Add SQLiteDataAdapter examples.

1fb2099

C#: Add SQLiteDataAdapter sinks.

aa13ab3

C#: Update SqlInjection query tests with new results.

86000f3

C#: Add some examples where adapter is used in conjunction with a tai…

78cfb22

…nted command.

C#: Add sinks and summaries for adapters with tainted commands.

fd67c34

C#: Update Sqlinjection test query output with new results.

344770f

C#: Add relevant stubs.

1e7e49a

C#: Add SecondOrder SQL injection example, where reading from a file.

2b51e03

michaelnebel force-pushed the csharp/webgoat branch from c88e98d to e912a5f Compare August 10, 2022 09:10

hvitved requested changes Aug 10, 2022

View reviewed changes

hvitved mentioned this pull request Aug 10, 2022

C#: Rename Argument[Qualifier] to Argument[this] in MaD #10004

Merged

michaelnebel added 8 commits August 10, 2022 14:49

C#: Update FlowSummaries test expected output after addition of new s…

ced9ee5

…ummaries.

C#: Update SecondOrder SQL Injection test case expected output with v…

1355931

…ulnerability from test case.

C#: Add testcase for unsanitized filename used in Filestream.

5c47ae3

C#: Update expected file for Sql injection and Second Order sql injec…

504160f

…tion (note that this is already a second order sql injection).

C#: Add summary models for the FileStream constructor.

36a7135

C#: Update SQL Injection with testcase with found vulnerability.

c3adb99

C#: Update flow summaries test case with new summaries.

da30436

C#: Add release note.

0d83b7c

michaelnebel force-pushed the csharp/webgoat branch from e912a5f to 0d83b7c Compare August 10, 2022 12:59

github-actions bot added the documentation label Aug 10, 2022

hvitved previously approved these changes Aug 10, 2022

View reviewed changes

tamasvajk reviewed Aug 10, 2022

View reviewed changes

csharp/ql/src/change-notes/2022-08-10-sqlinjection-queries.md Outdated Show resolved Hide resolved

C#: Update release note.

9cb4e4a

michaelnebel dismissed hvitved’s stale review via 9cb4e4a August 11, 2022 06:57

michaelnebel requested a review from hvitved August 12, 2022 14:13

hvitved approved these changes Aug 15, 2022

View reviewed changes

michaelnebel merged commit 1590633 into github:main Aug 15, 2022

michaelnebel deleted the csharp/webgoat branch August 15, 2022 11:22

C#: SQL Injection improvements for SQLite. #9923

C#: SQL Injection improvements for SQLite. #9923

Uh oh!

Conversation

michaelnebel commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Jul 29, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 2, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 2, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 2, 2022

csharp

Generated file changes for csharp

Uh oh!

Uh oh!

github-actions bot commented Aug 2, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 2, 2022

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Aug 2, 2022

csharp

Generated file changes for csharp

Uh oh!

Uh oh!

github-actions bot commented Aug 10, 2022

csharp

Generated file changes for csharp

Uh oh!

hvitved left a comment

Choose a reason for hiding this comment

Uh oh!

michaelnebel commented Aug 10, 2022

Uh oh!

github-actions bot commented Aug 10, 2022

csharp

Generated file changes for csharp

Uh oh!

Uh oh!

github-actions bot commented Aug 11, 2022

csharp

Generated file changes for csharp

Uh oh!

michaelnebel commented Aug 11, 2022

Uh oh!

michaelnebel commented Aug 12, 2022

Uh oh!

hvitved commented Aug 15, 2022

Uh oh!

michaelnebel commented Aug 15, 2022

Uh oh!

hvitved commented Aug 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

michaelnebel commented Jul 29, 2022 •

edited

Loading