Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix New-Release cmdlet by also building also for v4 and misc. improvements #996

Merged
merged 1 commit into from May 17, 2018
Merged

Fix New-Release cmdlet by also building also for v4 and misc. improvements #996

merged 1 commit into from May 17, 2018

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented May 10, 2018

PR Summary

  • Important fix is to also build the release for v4.
  • I also reorded it so that it builds v 3,4,5,6 in order to satisfy my inner OCD. ;)
  • Minor improvement of error message for platyPS requirement check

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
@bergmeister
fix release script by building also for v3 and misc. improvements
Loading status checks…
167ab2b
@bergmeister bergmeister added this to the 1.17 milestone May 10, 2018
@bergmeister bergmeister self-assigned this May 10, 2018
@bergmeister bergmeister requested a review from JamesWTruher May 10, 2018
@bergmeister
bergmeister reviewed May 10, 2018
View changes
Utils/ReleaseMaker.psm1
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV3Release -Build
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV4Release -Build

This comment has been minimized.

Sign in to view
@bergmeister

bergmeister May 10, 2018 Author Collaborator

The essential bug was that it was not being built for version 4, the rest is just re-ordering that it builds v 3,4,5,6 in order for better readability

This comment has been minimized.

Sign in to view
@JamesWTruher

JamesWTruher May 11, 2018 Member

the 1.16.1 version of Script Analyzer did not include a PSv4 directory. So we haven't shipped it for a long while. Has there been an issue with this? Is there any strong reason why we should start shipping a v4 version when we haven't previously?
@JamesWTruher
JamesWTruher reviewed May 11, 2018
View changes
Copy link
Member

JamesWTruher left a comment

I'm not sure we should release a v4 version
Utils/ReleaseMaker.psm1
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV3Release -Build
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV4Release -Build

This comment has been minimized.

Sign in to view
@JamesWTruher

JamesWTruher May 11, 2018 Member

the 1.16.1 version of Script Analyzer did not include a PSv4 directory. So we haven't shipped it for a long while. Has there been an issue with this? Is there any strong reason why we should start shipping a v4 version when we haven't previously?
@bergmeister
Copy link
Collaborator Author

bergmeister commented May 11, 2018 •
edited

@JamesWTruher we already used to ship a folder for psv34 (and fullclr and coreclr) but PR #919 that fixed the references to SMA to be correct, split v3 and v4 (leading to much better behaviour for v3). The psm1 file has custom code here to pick the right binaries for the right version. PSSA will not work on v4 without this PR
@JamesWTruher JamesWTruher merged commit 606c9eb into PowerShell:development May 17, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher

Assignees

@bergmeister bergmeister

Labels
Area - Build
Projects
None yet
Milestone
1.17
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bergmeister @JamesWTruher
You can’t perform that action at this time.