Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux/macOS and WMF3/4 that are used by UseCompatibleCmdlets rule #954

Merged
merged 6 commits into from May 17, 2018
Merged

Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux/macOS and WMF3/4 that are used by UseCompatibleCmdlets rule #954

merged 6 commits into from May 17, 2018

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Mar 30, 2018 •
edited

PR Summary

Related #127
Update cmdlet type files used by UseCompatibleCmdlets for PowerShell Core 6.0.2 for Windows/Linux/macOs (thanks @JamesWTruher for the mac one), remove the old alpha ones and add the one for Windows PowerShell v3 (thanks @tylerl0706) and Windows PowerShell v4 (extracted from new winserver2012r2 azure VM)
Generate by running pwsh -noprofile; cd /path/to/PSSARepo/Utils; .\New-CommandDataFile.ps1
On the Windows side, I was running the lastest version of Windows 10 Home 10.0.16299.251 and on Linux, it was Ubuntu 16.04 (LTS).

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
bergmeister added 2 commits Mar 30, 2018
@bergmeister
add typedate for pwsh 6.0.2 on Windows 10.0.16299.251 and for Linux f…
c942fde 
…rom Ubuntu 16 (LTS)
@bergmeister
update docs and remove old alpha versions for windows/linux
Loading status checks…
59fc77d
@bergmeister bergmeister added this to the 1.17 milestone Mar 30, 2018
@bergmeister bergmeister self-assigned this Mar 30, 2018
@bergmeister bergmeister requested a review from JamesWTruher Mar 30, 2018
@bergmeister bergmeister mentioned this pull request Mar 30, 2018
Closed
@bergmeister bergmeister changed the title Add Type files of PowerShell Core 6.0.2 for Windows/Linux being used by UseCompatibleCmdlets rule Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux being used by UseCompatibleCmdlets rule Mar 30, 2018
@bergmeister
add v3 command data file from Tyler. And add v5.1 to docs as well
Loading status checks…
210d618
@bergmeister bergmeister mentioned this pull request Mar 31, 2018
Open
@bergmeister bergmeister changed the title Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux being used by UseCompatibleCmdlets rule Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux being and WMF3 used by UseCompatibleCmdlets rule Mar 31, 2018
@bergmeister
add wmf4 command data file produced on new vanilla winserver2012r2 az…
Loading status checks…
8b7641d 
…ure machine
@bergmeister bergmeister changed the title Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux being and WMF3 used by UseCompatibleCmdlets rule Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux being and WMF3/4 used by UseCompatibleCmdlets rule Mar 31, 2018
@bergmeister bergmeister changed the title Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux being and WMF3/4 used by UseCompatibleCmdlets rule Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux and WMF3/4 that are used by UseCompatibleCmdlets rule Apr 1, 2018
@bergmeister bergmeister mentioned this pull request Apr 3, 2018
Closed
6 of 7 tasks complete
@bergmeister bergmeister removed this from the 1.17 milestone Apr 4, 2018
@JamesWTruher
Copy link
Member

JamesWTruher commented Apr 9, 2018

core.macos.zip
here's the mac file - note the name change from osx to macos
otherwise this is fine, although I think Maria's PR will supercede this
bergmeister added 2 commits Apr 9, 2018
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
9c4ee4b 
…nalyzer into TypeFiles
@bergmeister
add mac command data file from James and correct it from osx to macOs
Loading status checks…
b10681f
@bergmeister bergmeister changed the title Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux and WMF3/4 that are used by UseCompatibleCmdlets rule Add CommandData files of PowerShell Core 6.0.2 for Windows/Linux/macOS and WMF3/4 that are used by UseCompatibleCmdlets rule Apr 9, 2018
@bergmeister bergmeister added this to the 1.17 milestone May 5, 2018
@bergmeister bergmeister mentioned this pull request May 6, 2018
Merged
@JamesWTruher
JamesWTruher approved these changes May 17, 2018
View changes
Copy link
Member

JamesWTruher left a comment

I didn't actually go line by line on the JSON files, let me know if you think I should.
@bergmeister
Copy link
Collaborator Author

bergmeister commented May 17, 2018

The json files are auto generated and I only skim-read it as well. I think it is fine.
@bergmeister bergmeister merged commit f1222ef into PowerShell:development May 17, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher

Assignees

@bergmeister bergmeister

Labels
Area - Rules
Projects
None yet
Milestone
1.17
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bergmeister @JamesWTruher
You can’t perform that action at this time.