Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTweak UseConsistentWhiteSpace formatting rule to exclude first unary operator when being used in argument #949
Conversation
|
since this is definitely improving the current experience, this isn't a blocking comment or one that requires a change, but I think this can go a bit further. |
| Invoke-Formatter '$foo.bar(-$a)' -Settings CodeFormatting | Should -Be $script | ||
| } | ||
|
|
||
| It "Should expand unary operators when not being used as a single negative argument" { |
This comment has been minimized.
This comment has been minimized.
JamesWTruher
Mar 28, 2018
Member
i'm not sure it's not just parens where this be applied. Take the following:
PS> Invoke-Formatter -ScriptDefinition '$r = $a -lt -$var'
$r = $a -lt - $var
shouldn't that be $r = $a -lt -$var?
This comment has been minimized.
This comment has been minimized.
bergmeister
Mar 28, 2018
•
Author
Collaborator
I agree with you. I extracted this into the new issue #950 to separate concerns and finish this PR. I am sure there are other special cases as well but I guess the best approach is to find them one by one and find heuristics to detect each case I suppose.
…ter/PSScriptAnalyzer into formatter_unaryOperator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedMar 26, 2018
•
edited
PR Summary
Fixes #847
When an expression like
$foo.bar(-$Var)is present, then theUseConsistentWhiteSpaceshould not expand spaces around this expression.This works by checking if the
-operator is an unary operator, is preceded by an open parenthesis and followed by a variable.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready