Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https links where possible #873

Merged
merged 1 commit into from Feb 7, 2018
Merged

Use https links where possible #873

merged 1 commit into from Feb 7, 2018

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Feb 5, 2018

PR Summary

Fixes #799
All links where checked and upgraded to https where possible.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • NA User facing documentation needed
  • Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
@bergmeister
use https links where possible (tested)
Loading status checks…
d7d751b
@bergmeister
bergmeister reviewed Feb 5, 2018
View changes
Engine/Commands/GetScriptAnalyzerRuleCommand.cs
@@ -23,7 +23,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands
/// <summary>
/// GetScriptAnalyzerRuleCommand: Cmdlet to list all the analyzer rule names and descriptions.
/// </summary>
[Cmdlet(VerbsCommon.Get, "ScriptAnalyzerRule", HelpUri = "http://go.microsoft.com/fwlink/?LinkId=525913")]
[Cmdlet(VerbsCommon.Get, "ScriptAnalyzerRule", HelpUri = "https://go.microsoft.com/fwlink/?LinkId=525913")]

This comment has been minimized.

Sign in to view
@bergmeister

bergmeister Feb 5, 2018 Author Collaborator

This link only re-directs to https://github.com/PowerShell/PSScriptAnalyzer/
Should we change it then to that?
@bergmeister
bergmeister reviewed Feb 5, 2018
View changes
Engine/Commands/InvokeScriptAnalyzerCommand.cs
@@ -39,7 +39,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands
"ScriptAnalyzer",
DefaultParameterSetName = "File",
SupportsShouldProcess = true,
HelpUri = "http://go.microsoft.com/fwlink/?LinkId=525914")]
HelpUri = "https://go.microsoft.com/fwlink/?LinkId=525914")]

This comment has been minimized.

Sign in to view
@bergmeister

bergmeister Feb 5, 2018 Author Collaborator

This link only re-directs to https://github.com/PowerShell/PSScriptAnalyzer/
Should we change it then to that?

This comment has been minimized.

Sign in to view
@JamesWTruher

JamesWTruher Feb 6, 2018 Member

@joeyaiello opinion?

This comment has been minimized.

Sign in to view
@JamesWTruher

JamesWTruher Feb 7, 2018 Member

the fwlink is fine - it's the way we handle links so it need not change if we move the repo. The real question is whether pointing to github is appropriate. I think for now it's fine.
@JamesWTruher JamesWTruher merged commit ed21cf8 into PowerShell:development Feb 7, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

HTTP endpoints should be HTTPS
2 participants
@bergmeister @JamesWTruher
You can’t perform that action at this time.