PowerShell / PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade platyPS from Version 0.5 to 0.9 #869

Merged

JamesWTruher merged 3 commits into PowerShell:development from bergmeister:updatePlatyPs_0_9

Feb 9, 2018

Collaborator

bergmeister commented Feb 4, 2018 •

edited

PR Summary

The current platyPS version is nearly 2 years old, therefore update it to not only get the latest bug fixes but also keep up to date to keep future upgrades easy.
Add build tools check for version as well and fix PSSA warning PSPossibleIncorrectComparisonWithNull in script
Also updates the platyPs markdown link to point directly to the release page.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
NA User facing documentation needed
Change is not breaking
NA Make sure you've added a new test if existing tests do not effectively test the code changed
This PR is ready to merge and is not work in progress
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

bergmeister added 3 commits


        Upgrade to platyPS Version 0.9


        improve check, error message and spelling in build tools (and a PSSA …

cf419ad

…warning about incorrect comparison with $null


        fix wrong version number

dbbe845

bergmeister changed the title ~~Upgrade to platyPS from Version 0.5 to 0.9~~ Upgrade platyPS from Version 0.5 to 0.9

JamesWTruher reviewed

  
            }

            Import-Module PlatyPS

            Import-Module platyPS

JamesWTruher Feb 6, 2018 Member

should this have -minimumversion 0.9.0?

bergmeister Feb 7, 2018 Author Collaborator

I thought this is not needed because we already checked on the line above that the user has a module with a version greater or equal to 0.9. Does Import-Module not always import the latest version in some case?
Would it in general be better to require that 0.9.x is exactly installed and not allow newer versions at all? Then we would need to use the -RequiredVersion parameter. What do you think?

JamesWTruher Feb 9, 2018 Member

Yes, it will import the latest version and there's a later test to be sure it meets the requirement. It's probably fine, just wanted to be sure.

JamesWTruher merged commit 54c4bf7 into PowerShell:development

2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded

Details

license/cla All CLA requirements met.

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.