Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FixPSUseDeclaredVarsMoreThanAssignments to also detect variables that are strongly typed #837

Merged
merged 2 commits into from Jan 20, 2018
Merged

Fix FixPSUseDeclaredVarsMoreThanAssignments to also detect variables that are strongly typed #837

merged 2 commits into from Jan 20, 2018

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Dec 3, 2017 •
edited

Fix issue #832
The problem was this line:

// Only checks for the case where lhs is a variable. Ignore things like $foo.property
VariableExpressionAst assignmentVarAst = assignmentAst.Left as VariableExpressionAst;

[string]$someVariable is a ConvertExpressionAst in this case and therefore I needed to do some work to get the VariableExpressionAst out of it in this case
bergmeister added 2 commits Dec 3, 2017
@bergmeister
Fix FixPSUseDeclaredVarsMoreThanAssignments to also detect variables …
Loading status checks…
faf4886 
…that are strongly typed.
@bergmeister
Add PSUseDeclaredVarsMoreThanAssignments test for strongly typed vari…
Loading status checks…
68840ac 
…ables
@JamesWTruher JamesWTruher merged commit a2ab2de into PowerShell:development Jan 20, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bergmeister @JamesWTruher
You can’t perform that action at this time.