Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix edge case of PSUseConsistentIndentation for non-default value (IncreaseIndentationForFirstPipeline/IncreaseIndentationAfterEveryPipeline) #1423
Conversation
added 3 commits
Mar 2, 2020
|
this looks fine |
| DiagnosticRecord = $violations[0] | ||
| CorrectionsCount = 1 | ||
| ViolationText = "baz" | ||
| CorrectionText = (New-Object -TypeName String -ArgumentList $indentationUnit, ($indentationSize * 1)) + 'baz' |
This comment has been minimized.
This comment has been minimized.
JamesWTruher
Mar 4, 2020
Member
this could also be written without using New-Object:
CorrectionText = ($indentationUnit * $indentationSize) + 'baz'it's sort of a toss up as to which one is more readable
This comment has been minimized.
This comment has been minimized.
bergmeister
Apr 4, 2020
Author
Collaborator
Good idea, thanks, I applied it, I could even remove the parenthesis because multiplication takes precedence over addition
added 2 commits
Apr 4, 2020
128a9a2
into
PowerShell:master
12 checks passed
12 checks passed
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1)
Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core)
Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1)
Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core)
Test Windows_Server2019_PowerShell_Core succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedMar 2, 2020
•
edited
PR Summary
Fixes #1406
The code assumed that the first pipe in a pipeline Ast is the last one on that line, which made the code not work in the following scenario (where it did not add the indentation in the 2nd line)
Therefore add code to be able to determine the last pipe on the line were the first pipe occurs
cc @felixfbecker
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.