Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46402: Promote SQLite URI tricks in sqlite3 docs #30660

Merged
merged 4 commits into from Jan 18, 2022
Merged

bpo-46402: Promote SQLite URI tricks in sqlite3 docs #30660

merged 4 commits into from Jan 18, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 18, 2022 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 18, 2022
nedbat
nedbat reviewed Jan 18, 2022
View changes
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
@nedbat
Copy link
Member

@nedbat nedbat commented Jan 18, 2022

This is great, thanks! I don't know if my vote counts for anything, but I approve. :)

@erlend-aasland @nedbat
Address review: Simplify URI explanation
ae5877e 
Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jan 18, 2022

Thanks for reviewing, @nedbat :)

@erlend-aasland erlend-aasland requested a review from ericvsmith Jan 18, 2022
@ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Jan 18, 2022

I think this looks great.

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jan 18, 2022

Thanks, Eric!

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jan 18, 2022

BTW, would you mind merging it? I don't have the commit bit.

@ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Jan 18, 2022

Will do.

@ericvsmith ericvsmith merged commit bdf2ab1 into python:main Jan 18, 2022
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 18, 2022

Thanks @erlend-aasland for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-doc-uri-tricks branch Jan 18, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 18, 2022

GH-30661 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 18, 2022

GH-30662 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 18, 2022
@erlend-aasland @miss-islington
bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-30660)
7b2d484 
Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 18, 2022
@erlend-aasland @miss-islington
bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-30660)
4c14a65 
Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jan 18, 2022

cc. @JulienPalard: I only need to update suspicious for the backports, right? (file: triggers the suspicious checks in 3.10 and 3.9).

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jan 18, 2022 •
edited

FYI: I'm closing the auto-backports and doing them myself in order to get the suspicious fixes into those.

ericvsmith pushed a commit that referenced this issue Jan 18, 2022
@erlend-aasland
[3.10] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (GH-30660) (
01e6cbe 
GH-30671)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (GH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update suspicious rules
ericvsmith pushed a commit that referenced this issue Jan 18, 2022
@erlend-aasland
[3.9] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (GH-30660) (…
0ae2257 
…#30672)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (GH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update suspicious rules
@nedbat nedbat mentioned this pull request May 16, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this issue Jun 2, 2022
@erlend-aasland @hello-adam
[3.9] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-…
7d252fb 
…30660) (python#30672)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (pythonGH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update suspicious rules
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedbat nedbat

@ericvsmith ericvsmith

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@erlend-aasland @nedbat @ericvsmith @miss-islington @bedevere-bot @the-knights-who-say-ni