Fix #315 Change the _KeywordOnlyArguments filtering condition #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
|
Up |
|
I'm going to merge this and then clean things up in a follow-up PR. The change we'll need to make is |
dbieber
added a commit
that referenced
this pull request
Apr 16, 2022
* #316 adds a test using Python 3 only features; this CL makes that test only run for Python 3 versions.
|
^Done in #389. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix #315 by changing the _KeywordOnlyArguments filtering condition.
The condition checked for the presence of the flag in the
kwonlydefaultsfield ofFullArgSpecto consider it as required, but that actually proved the opossite.