Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Similar to test_grp in test_pwd, add a test with null value in name #95376

Closed
Yaminyam opened this issue Jul 28, 2022 · 2 comments
Closed

Similar to test_grp in test_pwd, add a test with null value in name #95376

Yaminyam opened this issue Jul 28, 2022 · 2 comments
Labels
tests Tests in the Lib/test dir

Comments

@Yaminyam
Copy link
Contributor

@Yaminyam Yaminyam commented Jul 28, 2022

Both getpwnam(name) and getgrnam(name) should return ValueErr if null is entered in the name value
In test_grp, the part is being tested, but in test_pwd, the part is not being tested.
Is it ok to write a PR that adds that test?
@Yaminyam Yaminyam added the type-bug An unexpected behavior, bug, or error label Jul 28, 2022
@mdboom
Copy link
Contributor

@mdboom mdboom commented Jul 28, 2022

Yes, I think a PR to add that test would be quite welcome. Thanks.

@bedevere-bot bedevere-bot mentioned this issue Jul 28, 2022
Merged
@Yaminyam Yaminyam mentioned this issue Jul 28, 2022
Open
@mdboom mdboom added tests Tests in the Lib/test dir and removed type-bug An unexpected behavior, bug, or error labels Jul 28, 2022
ambv pushed a commit that referenced this issue Aug 6, 2022
@Yaminyam @erlend-aasland
�gh-95376: Add test for names containing null (#GH-5394)
a17cd47 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2022
@Yaminyam @miss-islington
�pythongh-95376: Add test for names containing null (GH-pythonGH-5394)
51a145a 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit a17cd47)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 6, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2022
@Yaminyam @miss-islington
�pythongh-95376: Add test for names containing null (GH-pythonGH-5394)
f7d4362 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit a17cd47)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 6, 2022
Merged
ambv pushed a commit that referenced this issue Aug 6, 2022
@miss-islington @Yaminyam
�gh-95376: Add test for names containing null (GH-GH-5394) (#GH-5746)
6dffb5f 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit a17cd47)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
ambv pushed a commit that referenced this issue Aug 6, 2022
@miss-islington @Yaminyam
gh-95376: Add test for names containing null (GH-GH-5394) (GH-95747)
f05a0f4 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit a17cd47)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@ambv
Copy link
Contributor

@ambv ambv commented Aug 6, 2022

This is now fixed in 3.10 - 3.12. Thanks! ✨ 🍰 ✨

@ambv ambv closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdboom @ambv @Yaminyam