Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_dataclass() does not work for dataclasses which are subclasses of types.GenericAlias #89826

Closed
Tracked in #89828
serhiy-storchaka opened this issue Oct 28, 2021 · 4 comments
Closed
Tracked in #89828

is_dataclass() does not work for dataclasses which are subclasses of types.GenericAlias #89826

serhiy-storchaka opened this issue Oct 28, 2021 · 4 comments
Labels
3.9 3.10 3.11 stdlib type-bug

Comments

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 28, 2021

BPO 45663
Nosy @gvanrossum, @ericvsmith, @serhiy-storchaka, @miss-islington
PRs
  • #29294
  • #29925
  • #29926
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-12-07.12:01:12.403>
created_at = <Date 2021-10-28.20:10:31.152>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'is_dataclass() does not work for dataclasses which are subclasses of types.GenericAlias'
updated_at = <Date 2021-12-07.12:01:12.402>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2021-12-07.12:01:12.402>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-07.12:01:12.403>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2021-10-28.20:10:31.152>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 45663
keywords = ['patch']
message_count = 4.0
messages = ['405256', '407739', '407743', '407745']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'eric.smith', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['29294', '29925', '29926']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45663'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @serhiy-storchaka
    Copy link
    Member Author

    @serhiy-storchaka serhiy-storchaka commented Oct 28, 2021 

    >>> import dataclasses, types
>>> @dataclasses.dataclass
... class A(types.GenericAlias):
...     origin: type
...     args: type
... 
>>> dataclasses.is_dataclass(A)
True
>>> a = A(list, int)
>>> dataclasses.is_dataclass(type(a))
True
>>> dataclasses.is_dataclass(a)
False

    @serhiy-storchaka serhiy-storchaka added 3.9 3.10 3.11 stdlib type-bug labels Oct 28, 2021
    @serhiy-storchaka
    Copy link
    Member Author

    @serhiy-storchaka serhiy-storchaka commented Dec 5, 2021

    New changeset 446be16 by Serhiy Storchaka in branch 'main':
    bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias (GH-29294)
    446be16

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Dec 5, 2021

    New changeset abceb66 by Miss Islington (bot) in branch '3.10':
    bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias (GH-29294)
    abceb66

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Dec 5, 2021

    New changeset 1905071 by Miss Islington (bot) in branch '3.9':
    bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias (GH-29294)
    1905071

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @serhiy-storchaka serhiy-storchaka mentioned this issue Jun 15, 2022
    Open
    7 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 3.10 3.11 stdlib type-bug
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington