Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-90817: Fix docs: use 'deprecated-removed' when removal version known #94960

Merged
merged 1 commit into from Aug 3, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 18, 2022

.. deprecated:: 3.11 3.13 should be .. deprecated-removed:: 3.11 3.13

So instead of:

Deprecated since version 3.11: 3.13

We get:

Deprecated since version 3.11, will be removed in version 3.13.

https://docs.python.org/3.12/library/locale.html#locale.getdefaultlocale

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 18, 2022
@hugovk hugovk requested a review from vstinner Jul 18, 2022
@vstinner vstinner merged commit dc2757a into python:main Aug 3, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 3, 2022

Thanks @hugovk for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2022
pythonGH-94960)

(cherry picked from commit dc2757a)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 3, 2022

GH-95627 is a backport of this pull request to the 3.11 branch.

@hugovk hugovk deleted the 90817-fix-deprecation-removed branch Aug 3, 2022
miss-islington added a commit that referenced this pull request Aug 3, 2022
…94960)

(cherry picked from commit dc2757a)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants