Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go-gh for SSH hostname alias translation #5654

Merged
merged 1 commit into from Jun 8, 2022
Merged

Use go-gh for SSH hostname alias translation #5654

merged 1 commit into from Jun 8, 2022

Conversation

samcoe
Copy link
Member

@samcoe samcoe commented May 16, 2022 •
edited

This PR introduces go-gh into gh in order to do SSH hostname alias translation. It replaces the existing implementation in ssh_config with the equivalent ssh package from go-gh. Additionally it changes context.TranslateRemotes to now take in a Translator interface.

cc #5560

@samcoe samcoe self-assigned this May 16, 2022
@samcoe samcoe mentioned this pull request May 16, 2022
Merged
@samcoe samcoe force-pushed the go-gh-integration-3 branch 3 times, most recently from 7308ef2 to 242a979 Compare May 23, 2022
@samcoe samcoe marked this pull request as ready for review May 23, 2022
@samcoe samcoe requested a review from a team as a code owner May 23, 2022
@samcoe samcoe requested review from mislav (assigned from cli/code-reviewers) and removed request for a team May 23, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI May 23, 2022
mislav
mislav approved these changes Jun 8, 2022
View changes
Copy link
Member

@mislav mislav left a comment

Love it!

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jun 8, 2022
@samcoe samcoe enabled auto-merge (squash) Jun 8, 2022
@samcoe samcoe merged commit 743a747 into trunk Jun 8, 2022
10 checks passed
@samcoe samcoe deleted the go-gh-integration-3 branch Jun 8, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jun 8, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav

Assignees

@samcoe samcoe

Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samcoe @mislav