bpo-40334: Improve various PEG-Parser related stuff #19669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all related to @vstinner's review of the PEP 617 PR. The most important changes include moving `pegen_interface.h` into `Include/internal` and refactoring some code in `Parser/pegen/pegen.c`.
|
Oh, this PR partially conflicts with my PR #19670. Would you mind to review it? |
Of course. Let me just first remove the conflicts from this one. |
vstinner
reviewed
Apr 23, 2020
vstinner
reviewed
Apr 23, 2020
|
Thanks for the help, @vstinner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These are all related to @vstinner's review of the PEP 617 PR.
The most important changes include moving
pegen_interface.hinto
Include/internaland refactoring some code inParser/pegen/pegen.c.https://bugs.python.org/issue40334