Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add diagnostics channel and perf hooks detail #43984

Merged
merged 1 commit into from Jul 29, 2022
Merged

lib: add diagnostics channel and perf hooks detail #43984

merged 1 commit into from Jul 29, 2022
+136 −17

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jul 25, 2022

  1. add diagnostics channel for net and udp.
  2. add perf hooks detail for dns.
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Jul 25, 2022

Review requested:

@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jul 25, 2022
VoltrexMaster
VoltrexMaster reviewed Jul 25, 2022
View changes
doc/api/diagnostics_channel.md Outdated Show resolved Hide resolved
doc/api/diagnostics_channel.md Outdated Show resolved Hide resolved
doc/api/perf_hooks.md Outdated Show resolved Hide resolved
@theanarkh theanarkh force-pushed the add_diagnostics_channel branch from d03ef60 to 5b903c0 Compare Jul 25, 2022
mscdex
mscdex reviewed Jul 25, 2022
View changes
doc/api/diagnostics_channel.md Outdated Show resolved Hide resolved
mscdex
mscdex reviewed Jul 25, 2022
View changes
doc/api/diagnostics_channel.md Outdated Show resolved Hide resolved
mscdex
mscdex reviewed Jul 25, 2022
View changes
doc/api/diagnostics_channel.md Outdated Show resolved Hide resolved
@theanarkh theanarkh force-pushed the add_diagnostics_channel branch 4 times, most recently from 262f4c8 to b5c79b1 Compare Jul 26, 2022
@nodejs nodejs deleted a comment from theanarkh Jul 26, 2022
@nodejs nodejs deleted a comment from theanarkh Jul 26, 2022
mcollina
mcollina approved these changes Jul 26, 2022
View changes
Copy link
Member

@mcollina mcollina left a comment

lgtm

@theanarkh theanarkh force-pushed the add_diagnostics_channel branch from b5c79b1 to 2f77e24 Compare Jul 26, 2022
@theanarkh theanarkh force-pushed the add_diagnostics_channel branch from 2f77e24 to d5f1c29 Compare Jul 27, 2022
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2022
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Jul 27, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45701/

@mcollina
Copy link
Member

mcollina commented Jul 27, 2022

CI is failing

@theanarkh theanarkh force-pushed the add_diagnostics_channel branch from d5f1c29 to 74838e6 Compare Jul 27, 2022
@theanarkh
Copy link
Contributor Author

theanarkh commented Jul 27, 2022 •
edited

Yes. DNS resolution fails. It seems like this issue. I have updated the test that just skip it if it fails. Is it ok ?

@theanarkh theanarkh force-pushed the add_diagnostics_channel branch from 74838e6 to b8ee52a Compare Jul 27, 2022
mcollina
mcollina approved these changes Jul 27, 2022
View changes
Copy link
Member

@mcollina mcollina left a comment

lgtm

@theanarkh theanarkh force-pushed the add_diagnostics_channel branch from b8ee52a to a832fdf Compare Jul 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2022
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Jul 27, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45709/

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2022
@nodejs-github-bot nodejs-github-bot merged commit 60898ee into nodejs:main Jul 29, 2022
50 checks passed
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Jul 29, 2022

Landed in 60898ee

This was referenced Aug 1, 2022
Open
Open
@joyeecheung joyeecheung mentioned this pull request Aug 2, 2022
Closed
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Aug 16, 2022
@danielleadams
Copy link
Member

danielleadams commented Aug 16, 2022

@theanarkh This broke the build for v18.x-staging - do you mind creating a backport PR?

@danielleadams danielleadams removed the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Aug 16, 2022
@kvakil kvakil mentioned this pull request Aug 16, 2022
Merged
@theanarkh
Copy link
Contributor Author

theanarkh commented Aug 16, 2022 •
edited

The error can be fixed by this PR(#44144). I will try to create a backport to v18.x-staging.

@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Aug 16, 2022
@theanarkh theanarkh mentioned this pull request Aug 16, 2022
Closed
theanarkh added a commit to theanarkh/node that referenced this pull request Aug 16, 2022
@theanarkh
lib: add diagnostics channel and perf hooks detail
7de711e 
PR-URL: nodejs#43984
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
@theanarkh theanarkh added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Aug 16, 2022
theanarkh pushed a commit to theanarkh/node that referenced this pull request Aug 17, 2022
@danielleadams @theanarkh
lib: add diagnostics channel and perf hooks detail
6abf79a 
PR-URL: nodejs#43984
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
theanarkh pushed a commit to theanarkh/node that referenced this pull request Aug 17, 2022
@danielleadams
lib: add diagnostics channel and perf hooks detail
62e2bbd 
PR-URL: nodejs#43984
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
theanarkh pushed a commit to theanarkh/node that referenced this pull request Aug 17, 2022
@danielleadams @theanarkh
lib: add diagnostics channel and perf hooks detail
8cbe1a7 
PR-URL: nodejs#43984
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
theanarkh pushed a commit to theanarkh/node that referenced this pull request Aug 17, 2022
@danielleadams @theanarkh
lib: add diagnostics channel and perf hooks detail
cf057b4 
PR-URL: nodejs#43984
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@danielleadams @theanarkh @ruyadorno
lib: add diagnostics channel and perf hooks detail
1a44fbc 
Co-Authored-By: theanarkh <theratliter@gmail.com>
PR-URL: #43984
Backport-PR-URL: #44256
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
@ruyadorno ruyadorno added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Aug 23, 2022
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
targos pushed a commit that referenced this pull request Sep 5, 2022
@danielleadams @theanarkh @targos
lib: add diagnostics channel and perf hooks detail
7ca6c9e 
Co-Authored-By: theanarkh <theratliter@gmail.com>
PR-URL: #43984
Backport-PR-URL: #44256
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@theanarkh @Fyko
lib: add diagnostics channel and perf hooks detail
8291847 
PR-URL: nodejs#43984
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex

@mcollina mcollina

@JungMinu JungMinu

@VoltrexMaster VoltrexMaster

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. dgram Issues and PRs related to the dgram subsystem / UDP. dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@theanarkh @nodejs-github-bot @mcollina @danielleadams @mscdex @JungMinu @VoltrexMaster @ruyadorno