Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest common components in FE directory #2640

Open
2 tasks
Kira-Pilot opened this issue Jun 24, 2022 · 0 comments
Open
2 tasks

Nest common components in FE directory #2640

Kira-Pilot opened this issue Jun 24, 2022 · 0 comments
Labels
brainbreak frontend good first issue

Comments

@Kira-Pilot
Copy link
Member

@Kira-Pilot Kira-Pilot commented Jun 24, 2022

As discussed in the FE variety meeting, we should nest certain common components within the same directory. You can read more about this decision, here.

Examples of component types which can all co-exist in common directories include:

  • modals, e.g. in a folder called modals
  • dialogs, e.g. in a folder called dialogs
  • tooltips, , e.g. in a folder called tooltips
  • maybe table components, e.g. in a folder called table_components

AC

  • components with many common members (examples above) should be moved into new, appropriately named directories
  • index.ts files should be added to each of these directories to import and then export those components.
@Kira-Pilot Kira-Pilot added frontend brainbreak good first issue labels Jun 24, 2022
@Kira-Pilot Kira-Pilot changed the title Nest common component in FE directory Nest common components in FE directory Jun 24, 2022
@Kira-Pilot Kira-Pilot self-assigned this Jun 24, 2022
@Kira-Pilot Kira-Pilot removed their assignment Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainbreak frontend good first issue
Projects
None yet
Development

No branches or pull requests

1 participant