Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand SSH Key text field #2052

Open
ammario opened this issue Jun 4, 2022 · 4 comments
Open

Expand SSH Key text field #2052

ammario opened this issue Jun 4, 2022 · 4 comments
Labels
feature frontend good first issue

Comments

@ammario
Copy link
Contributor

@ammario ammario commented Jun 4, 2022

Screen Shot 2022-06-04 at 1 45 52 PM

should show the full text field without scrolling IMO. The SSH key has a static size so a constant-dimension solution presents well.
@ammario ammario added good first issue feature labels Jun 4, 2022
@ketang
Copy link
Contributor

@ketang ketang commented Jun 4, 2022

I agree there should be no scrollbars, but doesn't the key length vary based on parameters and algorithm?

@ammario
Copy link
Contributor Author

@ammario ammario commented Jun 4, 2022

Since we control the algorithm, not really. The OpenSSH cleartext representation of the ed25519 public key is always 68 chars. If we switch to another elliptic curve algo it will be roughly similar.

@ketang
Copy link
Contributor

@ketang ketang commented Jun 4, 2022

I guess if and when we support something else we can probably adjust the size of the area correspondingly.

@f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Jun 10, 2022

Yeah just went to report this and found this, this looks pretty rough

@misskniss misskniss added the frontend label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature frontend good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ketang @misskniss @ammario @f0ssel