Add ABI dump script #94135
Merged
Add ABI dump script #94135
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8692028
to
a48758e
Compare
encukou
approved these changes
Jun 23, 2022
Looks good, two little improvements below.
I checked with podman run -v$(pwd):/src:Z -w /src --rm -it ubuntu:20.04 bash /src/.github/workflows/regen-abidump.sh. Two changes to carry over to the Docker command line:
-w /srcfor the working directory--rmto remove the container:- If you aren't familiar with containers you probably don't want used ones lying around.
- If you do want to keep it around, you probably know what
--rmis and can remove it.
|
Thanks a lot for the review @encukou |
|
I will make the PR to fix the devguide soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.