Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FAQ topic and link from main index #513

Merged
merged 4 commits into from Jun 15, 2022
Merged

Adding FAQ topic and link from main index #513

merged 4 commits into from Jun 15, 2022

Conversation

idanenglander
Copy link
Contributor

@idanenglander idanenglander commented Jun 13, 2022

I did away with the designation of FAQ - general and FAQ - technical, but I can add those back in and adjust headers as needed.

I also did not include the internal only section.

kathatherine
kathatherine previously requested changes Jun 14, 2022
docs/reference/faq.md Outdated Show resolved Hide resolved
docs/reference/faq.md Outdated Show resolved Hide resolved
docs/reference/faq.md Outdated Show resolved Hide resolved
docs/reference/faq.md Outdated Show resolved Hide resolved
@idanenglander idanenglander requested a review from kathatherine Jun 15, 2022
@idanenglander idanenglander dismissed kathatherine’s stale review Jun 15, 2022

Dismissing review because I've already processed the feedback

Copy link

@kathatherine kathatherine left a comment

LGTM! Thanks!

@fpliger fpliger merged commit 1e09ac4 into main Jun 15, 2022
2 checks passed
@fpliger fpliger deleted the FAQ branch Jun 15, 2022
Copy link
Collaborator

@fpliger fpliger left a comment

lgtm

@fpliger fpliger added the tag: docs label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants