FYI small changes to makefile and such in #418, would probably merge in main.

@marimeireles is this one ready for review?

This is on a forked branch so I can't edit it too easily, but @marimeireles if you could integrate some of the extra changes from #435 into this I'd appreciate it. Tag me for review when you can.

@pww217 I'll look into it right now :)
Should have something in the next few hours.

Some points:

• In order to test pyscript I need to build it first

So I ask myself if we should just remove the the build step from the CI.
I think it's better than removing it from the make test from the Makefile because if we don't remove, means we can test everything with one command.
Not sure! whats the best to do. I'll leave it to you. =)

• I don't think these tests failing are related to this PR?

Not sure I fully understand. You basically mean you're integrating the build process into your examples testing?

So long as the build artifact exists and is ready to be shipped, we can do it in whatever order we want.

I think for clarity I'd rather see these separated out into distinct make commands, but put in a logic order.

So it seems like we're want it to look like this:

make example
make build
make test
sync

Then assuming the build itself is still where it usually is at examples/build/pyscript.js, etc. we can copy it to S3 as a deployment. Does that make sense?

The failing tests may have to do with the fact that we lose some files by moving the examples dir, but I'm not sure why we lose them.

The failing tests may have to do with the fact that we lose some files by moving the examples dir, but I'm not sure why we lose them.

I thought I saw it failing on other PRs too, but no.
I'll investigate =) Thanks.

And I see what you mean, I agree. Will change.

On the question about removing build from CI. I think it's fine to say that we have to build it locally to test locally and CI can do the same. It actually ensures that the build works in different achitectures.