Python/JS/Ruby: Ignore common words (like certain) as sensitive data source#9649
Merged
RasmusWL merged 6 commits intogithub:mainfrom Jun 23, 2022
Merged
Python/JS/Ruby: Ignore common words (like certain) as sensitive data source#9649RasmusWL merged 6 commits intogithub:mainfrom
RasmusWL merged 6 commits intogithub:mainfrom
Conversation
yoff
approved these changes
Jun 22, 2022
erik-krogh
approved these changes
Jun 23, 2022
Member
Author
|
experiments looks good, so will merge 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9632
I tested our old regexes against
/usr/share/dict/words, and we had quite a few matches that were nonsens, likeconcertfor a certificate, orsecretaryas a secret 😬The change from the few allow-list words I've added can be seen below.
(also introduced a small fix for snake_case support)
If you review commit by commit, you can see the fixes being applied to the tests.