add devcontainer #5592
Merged
add devcontainer #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
approved these changes
May 9, 2022
This looks great! Thank you.
And if this repository didn't have any .devcontainer configuration and someone opened a Codespace for it, wouldn't they also get a VS Code instance with Go preinstalled and the golang.go extension enabled? At least, that's how I remember hacking on CLI from Codespaces before. Does this configuration just enable us to have greater control over the Go version used?
|
In Codespaces, if a We're now defaulting to 1.18 in the default image, but that may change - so it is nice we now have the devcontainer to enforce consistency :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
closes #5582
Adds a devcontainer installing
go1.18 for use in GitHub Codespaces and the VS Code Remote-Containers extension.Based on See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.234.0/containers/go/.devcontainer/base.Dockerfile