Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The inline cache for LOAD_ATTR is too large. #93533

Open
markshannon opened this issue Jun 6, 2022 · 1 comment
Open

The inline cache for LOAD_ATTR is too large. #93533

markshannon opened this issue Jun 6, 2022 · 1 comment
Labels
3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@markshannon
Copy link
Member

markshannon commented Jun 6, 2022 •
edited by bedevere-bot

The inline cache for LOAD_METHOD takes 10 code units, which is considerably larger than other inline caches, and is an obstacle to merging LOAD_ATTR and LOAD_METHOD (#93430), as LOAD_ATTR is such a common instruction.

See faster-cpython/ideas#396 for some ideas on how to shrink the inline cache.

Linked PRs
@markshannon markshannon added the performance Performance or resource usage label Jun 6, 2022
@markshannon markshannon mentioned this issue Jun 6, 2022
Merged
@iritkatriel iritkatriel added the 3.12 bugs and security fixes label Sep 8, 2022
@bedevere-bot bedevere-bot mentioned this issue Mar 24, 2023
Closed
@markshannon markshannon changed the title The inline cache for LOAD_METHOD is too large. The inline cache for LOAD_ATTR is too large. Oct 31, 2023
@markshannon
Copy link
Member Author

LOAD_METHOD has been merged into LOAD_ATTR, which means that the inline cache for LOAD_ATTR is too large.
Changed the title reflect this.

@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iritkatriel @markshannon