Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36373: Deprecate explicit loop in task and subprocess API #16033

Merged
merged 11 commits into from Sep 12, 2019
Merged

bpo-36373: Deprecate explicit loop in task and subprocess API #16033

merged 11 commits into from Sep 12, 2019

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Sep 12, 2019 •
edited

@asvetlov asvetlov requested review from 1st1 and gpshead as code owners Sep 12, 2019
@asvetlov
Copy link
Contributor Author

asvetlov commented Sep 12, 2019

The PR passes tests with -Werror flag

@asvetlov asvetlov merged commit a488879 into python:master Sep 12, 2019
@asvetlov asvetlov deleted the bpo-36373-task branch Sep 12, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Sep 12, 2019

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 12, 2019

GH-16039 is a backport of this pull request to the 3.8 branch.

@asvetlov asvetlov mentioned this pull request Sep 12, 2019
Closed
miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @asvetlov
bpo-36373: Deprecate explicit loop in task and subprocess API (GH-16033)
345bfc9 
(cherry picked from commit a488879)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@gpshead gpshead

Assignees
No one assigned
Labels
expert-asyncio skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asvetlov @miss-islington @bedevere-bot @the-knights-who-say-ni @eamanu