[3.8] closes bpo-37405: Make socket.getsockname() always return a tuple for AF_CAN. (GH-14392)#16018
Merged
benjaminp merged 1 commit intopython:3.8from Sep 12, 2019
Merged
Conversation
… AF_CAN. (pythonGH-14392) This fixes a regression from 3.5. In recent releases, `getsockname()` in the AF_CAN case has returned a string. (cherry picked from commit 954900a) Co-authored-by: bggardner <brent@ebrent.net>
benjaminp
approved these changes
Sep 12, 2019
Contributor
Author
|
@bggardner and @benjaminp: Status check is done, and it's a success ✅ . |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
benjaminp
approved these changes
Sep 12, 2019
Contributor
Author
|
@bggardner and @benjaminp: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@bggardner and @benjaminp: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression from 3.5. In recent releases,
getsockname()in the AF_CAN case has returned a string.(cherry picked from commit 954900a)
Co-authored-by: bggardner brent@ebrent.net
https://bugs.python.org/issue37405