Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.8] bpo-37972: unittest.mock._Call now passes on __getitem__ to the __getattr__ chaining so that call() can be subscriptable (GH-15565) #15965
+31
−0
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Sep 11, 2019
bedevere-bot
added
the
awaiting review
label
Sep 11, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Sep 11, 2019
voidspace
merged commit db0d8a5
into
python:3.8
Sep 12, 2019
5 of 6 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
News entry found in Misc/NEWS.d
bedevere-bot
removed
the
awaiting merge
label
Sep 12, 2019
miss-islington
deleted the
miss-islington:backport-72c3599-3.8
branch
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
miss-islington commentedSep 11, 2019
•
edited by bedevere-bot
bpo-37972: unittest.mock._Call now passes on getitem to the getattr chaining so that call() can be subscriptable
Update 2019-08-28-21-40-12.bpo-37972.kP-n4L.rst
added name of the contributor
bpo-37972: made all dunder methods chainable for _Call
bpo-37972: delegate only attributes of tuple instead to getattr
(cherry picked from commit 72c3599)
Co-authored-by: blhsing github@ydooby.com
https://bugs.python.org/issue37972