Skip to content

bpo-36991: Fix incorrect exception escaping ZipFile.extract()#13632

Merged
gpshead merged 3 commits intopython:masterfrom
berkerpeksag:36991-zipfile
Sep 12, 2019
Merged

bpo-36991: Fix incorrect exception escaping ZipFile.extract()#13632
gpshead merged 3 commits intopython:masterfrom
berkerpeksag:36991-zipfile

Conversation

@berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented May 28, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented May 28, 2019

Maybe add a NEWS entry?

@berkerpeksag
Copy link
Member Author

berkerpeksag commented May 28, 2019

Thanks for the review, Serhiy! Yes, I'm going to add it before merging the PR.

@taleinat
Copy link
Contributor

taleinat commented Jun 27, 2019

Ping! This is ready to go except for a NEWS entry, so we should really just get it over with...

@gpshead gpshead changed the title bpo-36991: Fix TypeError in ZipFile.extract() bpo-36991: Fix incorrect exception escaping ZipFile.extract() Sep 12, 2019
@gpshead gpshead self-assigned this Sep 12, 2019
@gpshead gpshead merged commit 2f1b857 into python:master Sep 12, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Sep 12, 2019

Thanks @berkerpeksag for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
@berkerpeksag @miss-islington
bpo-36991: Fix incorrect exception escaping ZipFile.extract() (python…
8cdaab6 
…GH-13632)

(cherry picked from commit 2f1b857)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 12, 2019

GH-16052 is a backport of this pull request to the 3.8 branch.

@taleinat
Copy link
Contributor

taleinat commented Sep 12, 2019

@gpshead, should this not also be backported to 3.7?

@miss-islington
Copy link
Contributor

miss-islington commented Sep 12, 2019

Thanks @berkerpeksag for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Sep 12, 2019

Sorry, @berkerpeksag and @gpshead, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2f1b857562b0f1601c9019db74c29b7d7e21ac9f 3.7

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Sep 12, 2019
miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @berkerpeksag
bpo-36991: Fix incorrect exception escaping ZipFile.extract() (GH-13632)
717cc61 
(cherry picked from commit 2f1b857)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
@berkerpeksag berkerpeksag deleted the 36991-zipfile branch September 12, 2019 16:39
@berkerpeksag
Copy link
Member Author

berkerpeksag commented Sep 12, 2019

@gpshead thank you for taking care of the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@gpshead gpshead

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@berkerpeksag @serhiy-storchaka @taleinat @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni