update README.md and CONTRIBUTING.md#254
Conversation
Corrected the grammatical mistakes to make the documents easier to read and understand.
shivaylamba
left a comment
There was a problem hiding this comment.
PyScript is a Pythonic alternative of Scratch, JSFiddle, or
instead of
PyScript is a Pythonic alternative of Scratch, JSFiddle or
|
Thanks for the suggestion @shivaylamba working on it. |
|
@jezdez can you please review this PR. |
fpliger
left a comment
There was a problem hiding this comment.
@jaynarayan-vaishnav thank you for your contribution! I'm not sure the change adds to the message in this part of the documentation. I checked the text with a tech writer and the change from "to" to "of" seems off in this context. Also, I wouldn't add "any".. I don't feel like we can claim that honestly (although our goal may be in that direction).
I would keep the change to remove that one comma after "hackable". :)
Happy to be convinced otherwise, or to merge if you are ok with the above comments. TY!
|
Do you mean that the corrections are unnecessary with respect to the context of this document? and i have to change it to how it was before? I agree with the removal of |
|
Oh, nothing to be sorry about :) , your help is much appreciated! Yeah, I mean that I'd revert to how it was before and just change the
|
|
okay, I got Your Point thanks for helping me. 😄 and can you also check the comments in #61 that I made after the PR got merged as kathatherine said I should create a new issue or directly make a PR for the new found issue . can you suggest to me what should I do about that it would be really helpful |
|
You can open a PR directly linking to the discussion you mentioned above or do it here, both are fine ways. If it was a big change I'd recommend opening a new issue/pr but seems a pretty limited change... 👍 |
made required changes
made necessary changes.
|
I have merged both the issues in the same PR. can you please Review it. |
|
@fpliger can you please review this PR. If there is something wrong i am ready to make changes |
|
@jaynarayan-vaishnav was looking at this just right now. I think we can merge the changes if you'd like to re-open it. |
|
@fpliger while i was fetching upstream there were some merge conflicts i will resolve them then reopen this PR if it's okay with you. |
|
I've resolved the merge conflict and opened the PR again. Please review it @fpliger . Sorry if I made some Mistakes while resolving the merge conflict It's my first time facing such an issue so I tried my best to resolve it. |
|
Hey @fpliger can you please review this otherwise there might be some conflicts like in the previous PR. Sorry for disturbing you time and again . |
Corrected the grammatical mistakes to make the documents easier to read and understand.