Upgrade to go 1.18 #5542
Merged
Upgrade to go 1.18 #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
approved these changes
May 4, 2022
This looks good; thanks for doing the migration!
Do you expect to get any benefit from the 1.18 migration? Are there some 1.17 or 1.18 features that we hope to use? Or is this purely housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR updates the project to Go 1.18.
As part of this PR I had to update our version of
golangci-lintto support the new Go version. With this new version there are four linters that are currently disabled as being unsupported:They are currently being worked on to support Go 1.18.
Additionally due to the fact that the
staticchecklinter is not supported and we use//nolint:staticcheckin a number of places to hide deprecation warnings from the linter I also had to disable thenolintlintlinter so these annotations do not cause linter errors.In the near future we will want to update our version of
golangci-lintto get these 5 linters re-enabled.