Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Lib/idlelib/idle_test/test_parenmatch.py unit test #93332

Merged
merged 2 commits into from May 30, 2022
Merged

Fix typo in Lib/idlelib/idle_test/test_parenmatch.py unit test #93332

merged 2 commits into from May 30, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented May 29, 2022

No description provided.

@luzpaz luzpaz requested a review from terryjreedy as a code owner May 29, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 29, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 29, 2022
terryjreedy
terryjreedy approved these changes May 30, 2022
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

With my changes.

@terryjreedy terryjreedy self-assigned this May 30, 2022
@terryjreedy
Copy link
Member

terryjreedy commented May 30, 2022

Thank you for the PR. I have seen the misspelling but left it because it "doesn't matter", except it does if I want others to carefully read idlelib files, which I do. The docstrings was also unclear.

@terryjreedy terryjreedy merged commit 4f195f9 into python:main May 30, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 30, 2022

Thanks @luzpaz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 30, 2022

GH-93339 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2022
@luzpaz @miss-islington
Fix typo in Lib/idlelib/idle_test/test_parenmatch.py (pythonGH-93332)
be36909 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2022
@luzpaz @miss-islington
Fix typo in Lib/idlelib/idle_test/test_parenmatch.py (pythonGH-93332)
88aa544 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented May 30, 2022

GH-93340 is a backport of this pull request to the 3.10 branch.

terryjreedy pushed a commit that referenced this pull request May 30, 2022
@miss-islington @luzpaz
Fix typo in Lib/idlelib/idle_test/test_parenmatch.py (GH-93332) (#93339)
da18451 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
terryjreedy pushed a commit that referenced this pull request May 30, 2022
@miss-islington @luzpaz
Fix typo in Lib/idlelib/idle_test/test_parenmatch.py (GH-93332) (#93340)
372afb7 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 4f195f9)

Co-authored-by: luzpaz <luzpaz@users.noreply.github.com>
@luzpaz luzpaz deleted the typo/test_parenmatch branch May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@luzpaz @terryjreedy @miss-islington @bedevere-bot @AlexWaygood