Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40468: Factor out class ExtPage in idlelib.configdialog #26618

Merged
merged 2 commits into from Jun 9, 2021
Merged

bpo-40468: Factor out class ExtPage in idlelib.configdialog #26618

merged 2 commits into from Jun 9, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 9, 2021 •
edited by bedevere-bot

@terryjreedy terryjreedy self-assigned this Jun 9, 2021
@terryjreedy
Copy link
Member Author

terryjreedy commented Jun 9, 2021

To see the changes involved in the new class, look at the first commit, before it was moved.

@terryjreedy terryjreedy merged commit 5571cab into python:main Jun 9, 2021
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 9, 2021

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Jun 9, 2021

Sorry @terryjreedy, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5571cabf1b3385087aba2c7c10289bba77494e08 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2021
@terryjreedy @miss-islington
bpo-40468: Factor out class ExtPage in idlelib.configdialog (pythonGH…
d03c929 
…-26618)

(cherry picked from commit 5571cab)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

bedevere-bot commented Jun 9, 2021

GH-26619 is a backport of this pull request to the 3.9 branch.

@terryjreedy terryjreedy deleted the extpage branch Jun 9, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jun 9, 2021

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 9, 2021

GH-26620 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2021
@terryjreedy @miss-islington
bpo-40468: Factor out class ExtPage in idlelib.configdialog (pythonGH…
3e7f1aa 
…-26618)

(cherry picked from commit 5571cab)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Jun 9, 2021
@miss-islington @terryjreedy
bpo-40468: Factor out class ExtPage in idlelib.configdialog (GH-26618)
c835323 
(cherry picked from commit 5571cab)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Jun 9, 2021
@miss-islington @terryjreedy
bpo-40468: Factor out class ExtPage in idlelib.configdialog (GH-26618)
33a7a24 
(cherry picked from commit 5571cab)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@terryjreedy terryjreedy

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni