bpo-1635741: Port _thread to multiphase init #23811
Open
+223
−90
Conversation
Port the _thread extension module to the multiphase initialization API (PEP 489) and convert its static types to heap types.
|
Sadly, the following test leaks:
Output:
I will investigate later why it leaks. |
|
Workaround for the leak:
|
|
Example of leaking tests:
These tests run |
|
I fixed the leak by adding a traverse function to the lock type (and convert it to a GC type). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Port the _thread extension module to the multiphase initialization
API (PEP 489) and convert its static types to heap types.
https://bugs.python.org/issue1635741