Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) #18065

Merged
merged 2 commits into from Feb 11, 2020
Merged

bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) #18065

merged 2 commits into from Feb 11, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jan 19, 2020 •
edited by miss-islington

@shihai1991 shihai1991 requested review from ncoghlan and encukou Jan 31, 2020
ncoghlan
ncoghlan approved these changes Feb 2, 2020
View changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

LGTM (given the relative simplicity of the module), but until I've reviewed a few more of these, I'd like to get a +1 from @encukou as well.

@encukou
Copy link
Member

encukou commented Feb 4, 2020

The catch it that the simple module exposes complex API, and multiphase init asserts that the module is expected to support sub-interpreters. Any module that manipulates some registry should get some extra attention :)
All looks OK here, since thePyCodec_* functions all use interpreter-specific state.
@Dormouse759, do you want to take a look?

@encukou encukou changed the title bpo-1635741: Port _codecs extension module to multiphase initialization(PEP 489) bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) Feb 11, 2020
@encukou encukou added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Feb 11, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 11, 2020

@shihai1991: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Feb 11, 2020

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 1ea45ae into python:master Feb 11, 2020
@shihai1991
Copy link
Member Author

shihai1991 commented Feb 11, 2020

Thanks, guys.

@encukou
Copy link
Member

encukou commented Feb 11, 2020

Thank you!

@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan

@encukou encukou

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shihai1991 @encukou @miss-islington @ncoghlan @the-knights-who-say-ni @bedevere-bot