Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"__lltrace__" seems to be wrong , "__ltrace__" is correct in Misc/SpecialBuilds.txt #78607

Closed
NojimaTakahide mannequin opened this issue Aug 18, 2018 · 9 comments
Closed

"__lltrace__" seems to be wrong , "__ltrace__" is correct in Misc/SpecialBuilds.txt #78607

NojimaTakahide mannequin opened this issue Aug 18, 2018 · 9 comments
Labels
3.7 3.8 docs type-bug

Comments

@NojimaTakahide
Copy link
Mannequin

@NojimaTakahide NojimaTakahide mannequin commented Aug 18, 2018

BPO 34426
Nosy @Mariatta, @pablogsal, @miss-islington, @danishprakash
PRs
  • #8822
  • #8915
  • #8916
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-08-25.02:08:01.544>
created_at = <Date 2018-08-18.05:35:11.033>
labels = ['3.8', 'type-bug', '3.7', 'docs']
title = '"__lltrace__"  seems to be wrong , "__ltrace__" is correct in Misc/SpecialBuilds.txt'
updated_at = <Date 2018-08-25.02:15:59.350>
user = 'https://bugs.python.org/NojimaTakahide'

    bugs.python.org fields:

    activity = <Date 2018-08-25.02:15:59.350>
actor = 'Mariatta'
assignee = 'docs@python'
closed = True
closed_date = <Date 2018-08-25.02:08:01.544>
closer = 'Mariatta'
components = ['Documentation']
creation = <Date 2018-08-18.05:35:11.033>
creator = 'Nojima Takahide'
dependencies = []
files = []
hgrepos = []
issue_num = 34426
keywords = ['patch']
message_count = 8.0
messages = ['323692', '323740', '323759', '323761', '324027', '324028', '324030', '324031']
nosy_count = 6.0
nosy_names = ['docs@python', 'Mariatta', 'pablogsal', 'miss-islington', 'Nojima Takahide', 'danishprakash']
pr_nums = ['8822', '8915', '8916']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34426'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @NojimaTakahide
    Copy link
    Mannequin Author

    @NojimaTakahide NojimaTakahide mannequin commented Aug 18, 2018

    In the Section "LLTRACE" of $(Python3.6-source)/Misc/SpecialBuilds.txt , it describes variable name is "__lltrace__",however it seems to be wrong, "__ltrace__" is correct. Would someone correct this document?

    @NojimaTakahide NojimaTakahide mannequin added docs type-bug labels Aug 18, 2018
    @danishprakash
    Copy link
    Mannequin

    @danishprakash danishprakash mannequin commented Aug 19, 2018

    however it seems to be wrong, "__ltrace__" is correct

    just curious how did you figure it out?

    @pablogsal
    Copy link
    Member

    @pablogsal pablogsal commented Aug 19, 2018

    Content

    Hi @nojima and thank you for the report. Do you mind doing a PR?

    If not, I can do it myself if you prefer.

    @danishprakash
    Copy link
    Mannequin

    @danishprakash danishprakash mannequin commented Aug 19, 2018

    @pablogsal I would love to fix this up

    @Mariatta
    Copy link
    Sponsor Member

    @Mariatta Mariatta commented Aug 25, 2018

    New changeset 09efe49 by Mariatta (Danish Prakash) in branch 'master':
    bpo-34426: fix typo (lltrace -> __ltrace__) (GH-8822)
    09efe49

    @Mariatta
    Copy link
    Sponsor Member

    @Mariatta Mariatta commented Aug 25, 2018

    Thanks!

    @Mariatta Mariatta closed this Aug 25, 2018
    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Aug 25, 2018

    New changeset 0dc75f0 by Miss Islington (bot) in branch '3.7':
    bpo-34426: fix typo (lltrace -> __ltrace__) (GH-8822)
    0dc75f0

    @Mariatta
    Copy link
    Sponsor Member

    @Mariatta Mariatta commented Aug 25, 2018

    New changeset b26fcd6 by Mariatta (Miss Islington (bot)) in branch '3.6':
    bpo-34426: fix typo (lltrace -> __ltrace__) (GH-8822)
    b26fcd6

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @sweeneyde
    Copy link
    Member

    @sweeneyde sweeneyde commented Apr 15, 2022

    I think it may have been that the documentation was correct, but the code had a typo:

    The typo was introduced in 2012 in this commit: 3c1e481

    I think "lltrace" (the variable names in the C code) is a better abbreviation for "low-level trace".

    Since this has been around for 10 years, at this point, we could give up and do the low-level tracing if either __ltrace__ or __lltrace__ is present in the global namespace.

    @sweeneyde sweeneyde reopened this Apr 15, 2022
    @sweeneyde sweeneyde mentioned this issue Apr 16, 2022
    Merged
    sweeneyde added a commit that referenced this issue Apr 16, 2022
    @sweeneyde
    gh-78607: Replace __ltrace__ with __lltrace__ (GH-91619)
    37965d2
    @sweeneyde sweeneyde closed this Apr 16, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 3.8 docs type-bug
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @Mariatta @pablogsal @terryjreedy @miss-islington @sweeneyde