Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39492: Fix a reference cycle between reducer_override and a Pickler instance #18266

Merged
merged 5 commits into from Feb 2, 2020
Merged

bpo-39492: Fix a reference cycle between reducer_override and a Pickler instance #18266

merged 5 commits into from Feb 2, 2020

Conversation

pierreglaser
Copy link
Contributor

@pierreglaser pierreglaser commented Jan 30, 2020 •
edited by miss-islington

This also needs a backport to 3.8

https://bugs.python.org/issue39492

Automerge-Triggered-By: @pitrou

@pierreglaser pierreglaser mentioned this pull request Jan 30, 2020
Closed
@pierreglaser
Copy link
Author

@pierreglaser pierreglaser commented Jan 31, 2020

@pitrou if you want to take a look.

pitrou
pitrou requested changes Feb 1, 2020
View changes
Copy link
Member

@pitrou pitrou left a comment

Thank you for noticing and for the fix.

Modules/_pickle.c Show resolved Hide resolved
Lib/test/pickletester.py Outdated Show resolved Hide resolved
Lib/test/pickletester.py Show resolved Hide resolved
Modules/_pickle.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 1, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pitrou pitrou added the 🤖 automerge label Feb 2, 2020
@miss-islington
Copy link

@miss-islington miss-islington commented Feb 2, 2020

@pierreglaser: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 0f2f35e into python:master Feb 2, 2020
9 checks passed
@miss-islington
Copy link

@miss-islington miss-islington commented Feb 2, 2020

Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@pierreglaser pierreglaser deleted the fix-pickler-reference-cycle branch Feb 2, 2020
@miss-islington
Copy link

@miss-islington miss-islington commented Feb 2, 2020

Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link

@miss-islington miss-islington commented Feb 2, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link

@miss-islington miss-islington commented Feb 2, 2020

Thanks @pierreglaser for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 2, 2020

GH-18316 is a backport of this pull request to the 3.8 branch.

pitrou added a commit that referenced this issue Feb 2, 2020
@pitrou @pierreglaser
[3.8] bpo-39492: Fix a reference cycle between reducer_override and a…
1723687 
… Pickler instance (GH-18266) (#18316)

https://bugs.python.org/issue39492

Automerge-Triggered-By: @pitrou
(cherry picked from commit 0f2f35e)

Co-authored-by: Pierre Glaser <pierreglaser@msn.com>
@miss-islington
Copy link

@miss-islington miss-islington commented Feb 3, 2020

Sorry, @pierreglaser, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0f2f35e15f9fbee44ce042b724348419d8136bc5 3.8

@miss-islington miss-islington self-assigned this Feb 3, 2020
@miss-islington
Copy link

@miss-islington miss-islington commented Feb 3, 2020

Sorry @pierreglaser, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0f2f35e15f9fbee44ce042b724348419d8136bc5 3.8

@pierreglaser
Copy link
Author

@pierreglaser pierreglaser commented Feb 4, 2020

I'm confused by the bot: was this PR well backported to 3.8? cc @pitrou

@pitrou
Copy link

@pitrou pitrou commented Feb 4, 2020

It was, but I had to do it manually because the bot failed for some reason.

opavlyuk pushed a commit to opavlyuk/cpython that referenced this issue Feb 12, 2020
@pierreglaser
bpo-39492: Fix a reference cycle between reducer_override and a Pickl…
829ffe5 
…er instance (pythonGH-18266)

This also needs a backport to 3.8


https://bugs.python.org/issue39492



Automerge-Triggered-By: @pitrou
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@pierreglaser @chrisburr
bpo-39492: Fix a reference cycle between reducer_override and a Pickl…
10d22a1 
…er instance (pythonGH-18266)

This also needs a backport to 3.8


https://bugs.python.org/issue39492



Automerge-Triggered-By: @pitrou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou

Assignees

@miss-islington miss-islington

Labels
CLA signed 🤖 automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pierreglaser @bedevere-bot @miss-islington @pitrou @the-knights-who-say-ni