New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Smalltalk] add support for Dolphin Smalltalk #2027
Conversation
|
|
||
| # Pharo Smalltalk Debug log file | ||
| PharoDebug.log | ||
|
|
||
| # Squeak Smalltalk Debug log file | ||
| SqueakDebug.log | ||
|
|
||
| # Dolphin Smalltalk source file | ||
| *.sml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me that these source files can be safely ignored. Do you have any links to documentation or discussion about these files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dolphin Smalltalk 7 fresh image is composed of 3 files:
- ImageName.chg
- ImageName.sml
- ImageName.img7
Then you create a Package where your own code is store and the package is what you have to version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can help https://github.com/dolphinsmalltalk/Contributions the official contribution repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you can see gitignore in the official repository of Dolphin Smalltalk.
https://github.com/dolphinsmalltalk/Dolphin/blob/master/.gitignore
| @@ -1,15 +1,24 @@ | |||
| # changes file | |||
| *.changes | |||
| *.chg | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing with these extensions - can you tell me about what they represent and why they can be safely ignored? Additional resources are definitely helpful here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Represents the same as in Pharo and Squeak (.changes).
When you save something (ctrl+s) this change is add to the chg file, everything you modify is added. This file is complemented by SML and IMG/IMG7 to create the complete image, but what is important to version are the code packages (.pac or *.pax - *.cls)
|
Hi @shiftkey do you need more information about this changes? |
|
@rejurime no, I'm good. Thanks for working through it with me! |
Reasons for making this change:
Add support to Dolphin Smalltalk, the template only have support to Pharo and Squeak.
Links to documentation supporting these rule changes: