deps: upgrade npm to 8.5.5 #42382
deps: upgrade npm to 8.5.5 #42382
Conversation
|
Fast-track has been requested by @nodejs-github-bot. Please |
This comment was marked as outdated.
This comment was marked as outdated.
Commit Queue failed- Loading data for nodejs/node/pull/42382
✔ Done loading data for nodejs/node/pull/42382
----------------------------------- PR info ------------------------------------
Title deps: upgrade npm to 8.5.5 (#42382)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch npm-robot:npm-8.5.5 -> nodejs:master
Labels npm, fast-track, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x
Commits 1
- deps: upgrade npm to 8.5.5
Committers 1
- npm team
PR-URL: https://github.com/nodejs/node/pull/42382
Fixes: https://github.com/omit
Fixes: https://github.com/remove
Fixes: https://github.com/remove
Fixes: https://github.com/add
Fixes: https://github.com/properly
Reviewed-By: Ruy Adorno
Reviewed-By: Mestery
Reviewed-By: Luigi Pinca
Reviewed-By: Mohammed Keyvanzadeh
Reviewed-By: Rich Trott
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42382
Fixes: https://github.com/omit
Fixes: https://github.com/remove
Fixes: https://github.com/remove
Fixes: https://github.com/add
Fixes: https://github.com/properly
Reviewed-By: Ruy Adorno
Reviewed-By: Mestery
Reviewed-By: Luigi Pinca
Reviewed-By: Mohammed Keyvanzadeh
Reviewed-By: Rich Trott
--------------------------------------------------------------------------------
ℹ This PR was created on Thu, 17 Mar 2022 20:22:34 GMT
✔ Approvals: 5
✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/42382#pullrequestreview-913663315
✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42382#pullrequestreview-913739709
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42382#pullrequestreview-914000896
✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42382#pullrequestreview-914633440
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42382#pullrequestreview-914956235
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-03-18T17:03:05Z: https://ci.nodejs.org/job/node-test-pull-request/43120/
- Querying data for job/node-test-pull-request/43120/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
* branch master -> FETCH_HEAD
✔ origin/master is now up-to-date
- Downloading patch for 42382
From https://github.com/nodejs/node
* branch refs/pull/42382/merge -> FETCH_HEAD
✔ Fetched commits as fff95aeea944..5dd5166dc84c
--------------------------------------------------------------------------------
[master 8ebbda492b] deps: upgrade npm to 8.5.5
Author: npm team
Date: Thu Mar 17 20:22:31 2022 +0000
190 files changed, 3560 insertions(+), 3233 deletions(-)
rewrite deps/npm/lib/utils/otplease.js (68%)
delete mode 100644 deps/npm/node_modules/@npmcli/git/node_modules/lru-cache/LICENSE
delete mode 100644 deps/npm/node_modules/@npmcli/git/node_modules/lru-cache/bundle/main.js
delete mode 100644 deps/npm/node_modules/@npmcli/git/node_modules/lru-cache/bundle/main.mjs
delete mode 100644 deps/npm/node_modules/@npmcli/git/node_modules/lru-cache/index.js
delete mode 100644 deps/npm/node_modules/@npmcli/git/node_modules/lru-cache/package.json
rename deps/npm/node_modules/{cli-columns/node_modules => }/ansi-regex/index.d.ts (100%)
rename deps/npm/node_modules/{cli-columns/node_modules => }/ansi-regex/index.js (100%)
rename deps/npm/node_modules/{cli-columns/node_modules => }/ansi-regex/license (100%)
rename deps/npm/node_modules/{cli-columns/node_modules => }/ansi-regex/package.json (100%)
rename deps/npm/node_modules/{string-width/node_modules => }/ansi-regex/readme.md (100%)
rename deps/npm/node_modules/cacache/{ => lib}/get.js (91%)
rename deps/npm/node_modules/cacache/{ => lib}/index.js (83%)
rename deps/npm/node_modules/cacache/{ => lib}/put.js (86%)
rename deps/npm/node_modules/cacache/{ => lib}/rm.js (80%)
delete mode 100644 deps/npm/node_modules/cacache/ls.js
delete mode 100644 deps/npm/node_modules/cacache/verify.js
delete mode 100644 deps/npm/node_modules/columnify/node_modules/ansi-regex/index.d.ts
delete mode 100644 deps/npm/node_modules/columnify/node_modules/ansi-regex/index.js
delete mode 100644 deps/npm/node_modules/columnify/node_modules/ansi-regex/license
delete mode 100644 deps/npm/node_modules/columnify/node_modules/ansi-regex/package.json
delete mode 100644 deps/npm/node_modules/columnify/node_modules/strip-ansi/index.d.ts
delete mode 100644 deps/npm/node_modules/columnify/node_modules/strip-ansi/index.js
delete mode 100644 deps/npm/node_modules/columnify/node_modules/strip-ansi/license
delete mode 100644 deps/npm/node_modules/columnify/node_modules/strip-ansi/package.json
delete mode 100644 deps/npm/node_modules/gauge/lib/demo.js
delete mode 100644 deps/npm/node_modules/gauge/node_modules/ansi-regex/index.d.ts
delete mode 100644 deps/npm/node_modules/gauge/node_modules/ansi-regex/index.js
delete mode 100644 deps/npm/node_modules/gauge/node_modules/ansi-regex/license
delete mode 100644 deps/npm/node_modules/gauge/node_modules/ansi-regex/package.json
delete mode 100644 deps/npm/node_modules/gauge/node_modules/strip-ansi/index.d.ts
delete mode 100644 deps/npm/node_modules/gauge/node_modules/strip-ansi/index.js
delete mode 100644 deps/npm/node_modules/gauge/node_modules/strip-ansi/license
delete mode 100644 deps/npm/node_modules/gauge/node_modules/strip-ansi/package.json
rename deps/npm/node_modules/hosted-git-info/{ => lib}/git-host-info.js (98%)
rename deps/npm/node_modules/hosted-git-info/{ => lib}/git-host.js (100%)
rename deps/npm/node_modules/hosted-git-info/{ => lib}/index.js (93%)
rename deps/npm/node_modules/{make-fetch-happen/node_modules => }/lru-cache/index.js (91%)
delete mode 100644 deps/npm/node_modules/make-fetch-happen/node_modules/lru-cache/bundle/main.js
delete mode 100644 deps/npm/node_modules/make-fetch-happen/node_modules/lru-cache/bundle/main.mjs
delete mode 100644 deps/npm/node_modules/make-fetch-happen/node_modules/lru-cache/package.json
delete mode 100644 deps/npm/node_modules/normalize-package-data/AUTHORS
rename deps/npm/node_modules/npm-packlist/{ => lib}/index.js (99%)
rename deps/npm/node_modules/read-package-json/{ => lib}/read-json.js (97%)
rename deps/npm/node_modules/{make-fetch-happen => semver}/node_modules/lru-cache/LICENSE (92%)
rename deps/npm/node_modules/{ => semver/node_modules}/lru-cache/index.js (100%)
create mode 100644 deps/npm/node_modules/semver/node_modules/lru-cache/package.json
delete mode 100644 deps/npm/node_modules/string-width/node_modules/ansi-regex/index.d.ts
delete mode 100644 deps/npm/node_modules/string-width/node_modules/ansi-regex/index.js
delete mode 100644 deps/npm/node_modules/string-width/node_modules/ansi-regex/license
delete mode 100644 deps/npm/node_modules/string-width/node_modules/ansi-regex/package.json
delete mode 100644 deps/npm/node_modules/string-width/node_modules/strip-ansi/index.d.ts
delete mode 100644 deps/npm/node_modules/string-width/node_modules/strip-ansi/index.js
delete mode 100644 deps/npm/node_modules/string-width/node_modules/strip-ansi/license
delete mode 100644 deps/npm/node_modules/string-width/node_modules/strip-ansi/package.json
rename deps/npm/node_modules/{cli-columns/node_modules => }/strip-ansi/index.d.ts (100%)
rename deps/npm/node_modules/{cli-columns/node_modules => }/strip-ansi/index.js (100%)
rename deps/npm/node_modules/{cli-columns/node_modules => }/strip-ansi/license (100%)
rename deps/npm/node_modules/{cli-columns/node_modules => }/strip-ansi/package.json (100%)
rename deps/npm/node_modules/{string-width/node_modules => }/strip-ansi/readme.md (99%)
create mode 100644 deps/npm/tap-snapshots/test/lib/commands/doctor.js.test.cjs
create mode 100644 deps/npm/test/fixtures/tnock.js
rewrite deps/npm/test/lib/commands/doctor.js (98%)
✔ Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
deps: upgrade npm to 8.5.5
https://github.com/nodejs/node/actions/runs/2007233825 |
|
I think we should change node-core-utils so that it doesn't try to do anything with Fixes: metadata. It doesn't need to be in the bottom block. Leave it wherever it is. Then it won't mess up commit messages like it did this one and now I have to land it manually rather than use the commit queue (which is fine, but there's no benefit AFAICT to this feature so let's remove it and have more reliable automations). |
|
Actually, it looks like it tried to pull the Fixes out of the PR text and not the commit message, I think? If so, yeah, let's definitely not do that. :-D |
|
Landed in 76d85a8 |
PR-URL: nodejs#42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Yes, that is what it does. I find that function very useful -- you can edit the PR description and add metadata which node-core-utils would pick up and insert into the commit message trailers. Now with the commit queue I think it's even more useful to be able to insert metadata from the GitHub web UI (i.e. editing the PR description) without having to amend a commit manually. What is going wrong here is that there's code to convert stuff like into the expanded full URL but it's picking up "fix" from the text that isn't meant to be a trailer. We should make the detection smarter -- maybe check for the beginning of lines? I think https://github.com/nodejs/node-core-utils/blob/919ec3b784a2589aa88a1b2629b98d57283555a4/lib/links.js#L3-L4 are the regexps involved. |
|
I've opened nodejs/node-core-utils#612, which should fix the detection of fixes for these npm update pull requests and allow them to be landable by the commit queue. |
PR-URL: #42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Notable changes: doc: * add @ShogunPanda to collaborators (Shogun) #42362 * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) #42149 http: * (SEMVER-MINOR) trace http client by perf_hooks (theanarkh) #42345 deps: * upgrade npm to 8.5.5 (npm team) #42382 * update undici to 4.15.1 (Michaël Zasso) #42246 PR-URL: #42425
Notable changes: doc: * add @ShogunPanda to collaborators (Shogun) #42362 * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) #42149 http: * (SEMVER-MINOR) trace http client by perf_hooks (theanarkh) #42345 deps: * upgrade npm to 8.5.5 (npm team) #42382 * update undici to 4.15.1 (Michaël Zasso) #42246 PR-URL: #42425
Notable changes: doc: * add @ShogunPanda to collaborators (Shogun) #42362 * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) #42149 http: * (SEMVER-MINOR) trace http client by perf_hooks (theanarkh) #42345 deps: * upgrade npm to 8.5.5 (npm team) #42382 * update undici to 4.15.1 (Michaël Zasso) #42246 PR-URL: #42425
PR-URL: nodejs#42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Notable changes: doc: * add @ShogunPanda to collaborators (Shogun) nodejs#42362 * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) nodejs#42149 http: * (SEMVER-MINOR) trace http client by perf_hooks (theanarkh) nodejs#42345 deps: * upgrade npm to 8.5.5 (npm team) nodejs#42382 * update undici to 4.15.1 (Michaël Zasso) nodejs#42246 PR-URL: nodejs#42425
v8.5.5 (2022-03-17)
Bug Fixes
0e7511d14#4261 fix(arborist): _findMissingEdges missing dependency due to inconsistent path separators (@salvadorj)c83069436#4547 fix: omit bots from authors (@wraithgar)f66da2ed8#4565 fix(owner): bypass cache when fetching packument (@wraithgar)f0c6e86ca#4572 fix: remove name from unpublished message (@wraithgar)f7e58fa74#4572 fix: remove "bug the author" message from package 404 (@wraithgar)5471ff5fe#4573 fix: add isntall alias to install (@wraithgar)84d19210e#4576 fix: properly shownpm view ./directory(@wraithgar)e9a2981f5#4578 fix(arborist): save workspace version (@ruyadorno)Documentation
a30405258#4580 docs: add foreground-scripts and ignore-scripts to commands (@wraithgar)2361a68e1#4582 docs: add isntall alias to install command (@wraithgar)8ff1dfaae#4575 docs: explain that linked deps neednpm installran in them (@wraithgar)ddbb505ec#4574 docs: explain that git-tag-version=false does not commit (@wraithgar)7c878b978#4584 docs: fix unpublish docs to auto generate usage (@wraithgar)Dependencies
fcc6acfa8#4562 deps:@npmcli/metavuln-calculator@3.0.16d3145014#4562 deps:pacote@13.0.4f6b771aab#4562 deps:make-fetch-happen@10.0.6e26548fb1#4562 deps:cacache@16.0.0915dda7ab#4562 deps:init-package-json@3.0.1f2ec2ef1f#4562 deps:read-package-json@5.0.0340fa51f4#4562 deps:pacote@13.0.59555a5f1d#4562 deps:npm-package-arg@9.0.1b2a494283#4562 deps:normalize-package-data@4.0.01cb88f4b3#4562 deps:hosted-git-info@5.0.0f95396a03#4562 deps:cacache@16.0.1aec2bfecc#4585 deps:cacache@16.0.2ed8ab63e4deps:libnpmpack@4.0.20b73bfa82deps:libnpmteam@4.0.2475d59b36deps:libnpmaccess@6.0.27201c7395deps:libnpmsearch@5.0.2f5df358c3deps:libnpmorg@4.0.2472e7dd7adeps:libnpmhook@8.0.2c901d7290deps:libnpmpublish@6.0.2aad53327fdeps:@npmcli/arborist@5.0.3b40136bcadeps:libnpmdiff@4.0.25d91201d1deps:libnpmexec@4.0.2