build: add corepack to the auto-updated dependencies #42090
Conversation
|
Review requested: |
Co-authored-by: Mestery <mestery@protonmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
@arcanis Out of curiosity, can this be tested on github action (in forked repo maybe)? |
|
Ideally this workflow should probably run in PRs but in "dry-run" mode, skipping the |
|
What would be the point of running this workflow in PRs? |
|
Oh, you mean only in PRs that make changes to the workflow itself? |
|
Yep exactly, to make sure that the CI env has all the tools needed and scripts are well-formed. But that can be a separate PR. |
Commit Queue failed- Loading data for nodejs/node/pull/42090 ✔ Done loading data for nodejs/node/pull/42090 ----------------------------------- PR info ------------------------------------ Title build: add corepack to the auto-updated dependencies (#42090) Author Maël Nison (@arcanis) Branch arcanis:mael/corepack-update-workflow -> nodejs:master Labels build, meta, needs-ci Commits 3 - build: add corepack to the auto-updated dependencies - Adds NEW_VERSION to the workflow - Prefers curl over wget Committers 2 - Maël Nison - GitHub PR-URL: https://github.com/nodejs/node/pull/42090 Reviewed-By: Antoine du Hamel Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42090 Reviewed-By: Antoine du Hamel Reviewed-By: Mestery -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 23 Feb 2022 10:04:53 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42090#pullrequestreview-891493735 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42090#pullrequestreview-892399315 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-02-25T14:16:09Z: https://ci.nodejs.org/job/node-test-pull-request/42786/ - Querying data for job/node-test-pull-request/42786/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42090 From https://github.com/nodejs/node * branch refs/pull/42090/merge -> FETCH_HEAD ✔ Fetched commits as 65b60b567688..6b9e24313c27 -------------------------------------------------------------------------------- [master cae4e61ee6] build: add corepack to the auto-updated dependencies Author: Maël Nison Date: Wed Feb 23 11:03:37 2022 +0100 2 files changed, 10 insertions(+), 5 deletions(-) [master 6924b0b082] Adds NEW_VERSION to the workflow Author: Maël Nison Date: Wed Feb 23 14:09:36 2022 +0100 1 file changed, 1 insertion(+) [master f6eac40263] Prefers curl over wget Author: Maël Nison Date: Thu Feb 24 12:20:27 2022 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/1901073096 |
|
Landed in e84b635 |
PR-URL: nodejs#42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: nodejs#42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
This diff auto-updates Corepack when new releases are made on the npm package.
Requested in nodejs/admin#660 (comment)