Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add legacy built-in functions to primordials #42049

Merged
merged 1 commit into from Feb 21, 2022

Conversation

Copy link
Contributor

@aduh95 aduh95 commented Feb 18, 2022

Add missing built-in functions to the primordials object.

@nodejs-github-bot nodejs-github-bot added the needs-ci label Feb 18, 2022
@benjamingr
Copy link

@benjamingr benjamingr commented Feb 18, 2022

Why (if they're not used)?

@aduh95
Copy link
Author

@aduh95 aduh95 commented Feb 18, 2022

They are used in the freeze_intrinsics module. But the actual reason I'm doing it is because I have another commit in the pipes to parse the ESLint config file to get the list of known globals instead of maintaining two lists manually. I can push the other commit in a draft PR if that helps assess the utility of this PR.

@benjamingr
Copy link

@benjamingr benjamingr commented Feb 19, 2022

That would be helpful

Copy link
Member

@RaisinTen RaisinTen left a comment

Does this complete the list of primordials?

@aduh95 aduh95 added author ready request-ci labels Feb 20, 2022
@github-actions github-actions bot removed the request-ci label Feb 20, 2022
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Feb 20, 2022

@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Feb 20, 2022

@aduh95 aduh95 merged commit df0e665 into nodejs:master Feb 21, 2022
55 of 56 checks passed
@aduh95
Copy link
Author

@aduh95 aduh95 commented Feb 21, 2022

Landed in df0e665

@aduh95 aduh95 deleted the more-primordials branch Feb 21, 2022
sxa pushed a commit to sxa/node that referenced this issue Mar 7, 2022
PR-URL: nodejs#42049
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@sxa sxa mentioned this pull request Mar 8, 2022
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
PR-URL: nodejs#42049
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
PR-URL: #42049
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
PR-URL: #42049
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
PR-URL: #42049
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready needs-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants