tools: fix bugs in prefer-primordials linter rule #42010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESLint rule would repport false positive if code is using an identifier that happens to have the same name as a primordials member.
Leko
approved these changes
Feb 16, 2022
28 tasks
26 tasks
Trott
reviewed
Feb 18, 2022
Co-authored-by: Rich Trott <rtrott@gmail.com>
Trott
approved these changes
Feb 18, 2022
|
Landed in 6700b5c |
26 tasks
20 tasks
20 tasks
bengl
added a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
The ESLint rule would repport false positive if code is using an identifier that happens to have the same name as a primordials member. PR-URL: nodejs#42010 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
bengl
added a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
The ESLint rule would repport false positive if code is using an identifier that happens to have the same name as a primordials member. PR-URL: nodejs#42010 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
bengl
added a commit
that referenced
this issue
Feb 21, 2022
The ESLint rule would repport false positive if code is using an identifier that happens to have the same name as a primordials member. PR-URL: #42010 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
bengl
added a commit
that referenced
this issue
Feb 21, 2022
The ESLint rule would repport false positive if code is using an identifier that happens to have the same name as a primordials member. PR-URL: #42010 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
22 tasks
bengl
added a commit
that referenced
this issue
Feb 22, 2022
The ESLint rule would repport false positive if code is using an identifier that happens to have the same name as a primordials member. PR-URL: #42010 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The ESLint rule would repport false positive if code is using an
identifier that happens to have the same name as a primordials member.
The text was updated successfully, but these errors were encountered: