New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: rename X509_NAME_FLAGS #42001
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
tniessen:crypto-rename-x509-name-flags
Feb 17, 2022
Merged
crypto: rename X509_NAME_FLAGS #42001
nodejs-github-bot
merged 1 commit into
nodejs:master
from
tniessen:crypto-rename-x509-name-flags
Feb 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents.
|
Review requested: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
33 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
28 tasks
addaleax
approved these changes
Feb 17, 2022
aduh95
approved these changes
Feb 17, 2022
|
Landed in 19370b3 |
26 tasks
|
Thanks for reviewing! :) |
26 tasks
20 tasks
20 tasks
bengl
pushed a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents. PR-URL: nodejs#42001 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bengl
pushed a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents. PR-URL: nodejs#42001 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bengl
pushed a commit
that referenced
this issue
Feb 21, 2022
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents. PR-URL: #42001 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bengl
pushed a commit
that referenced
this issue
Feb 21, 2022
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents. PR-URL: #42001 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
22 tasks
nodejs-github-bot
pushed a commit
that referenced
this issue
Feb 22, 2022
For backward compatibility, node uses X509_NAME_oneline to format X509_NAME entries in PrintGeneralName. However, the format produced by this function is non-standard and its use is discouraged. It also does not handle Unicode names correctly. This change switches to X509_NAME_print_ex with flags that produce an RFC2253-compatible format. Non-ASCII strings are converted to UTF-8 and preserved in the output. Control characters are not escaped by OpenSSL when producing the RFC2253 format because they will be escaped by node in a JSON-compatible manner afterwards. PR-URL: #42002 Refs: #42001 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bengl
pushed a commit
that referenced
this issue
Feb 22, 2022
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents. PR-URL: #42001 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this issue
Apr 21, 2022
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents. PR-URL: nodejs#42001 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this issue
Apr 24, 2022
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with the naming conventions we use for constexpr values, to distinguish it from OpenSSL's built-in X509 constants, and to clarify what specific X509 name flags the constant represents. PR-URL: #42001 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Rename
X509_NAME_FLAGStokX509NameFlagsMultilineconstexprvalues,X509constants, and