fs: fix writev empty array error behavior #41919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
approved these changes
Feb 10, 2022
ronag
approved these changes
Feb 10, 2022
|
Are |
|
They throw a catchable error which is a lot less bad but the behavior for empty arrays should probably be adjusted there too (probably in a separate PR). I think we need to think how we do argument handling because it's currently very easy to make Node abort by passing a problematic argument. That is - a lot more than just writeev is affected and I'd guess most methods break on problematic input (subclasses or types or proxies) |
JungMinu
approved these changes
Feb 11, 2022
|
Landed in a137eca |
bengl
added a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
PR-URL: nodejs#41919 Fixes: nodejs#41910 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
bengl
added a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
PR-URL: nodejs#41919 Fixes: nodejs#41910 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes: #41910
Alternatively - we can error on an empty array but I like this behavior better.
cc @nodejs/fs @jasnell
The text was updated successfully, but these errors were encountered: